From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3861DC4338F for ; Tue, 3 Aug 2021 10:17:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EDA560F58 for ; Tue, 3 Aug 2021 10:17:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7EDA560F58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mArUG-00007t-JC for qemu-devel@archiver.kernel.org; Tue, 03 Aug 2021 06:17:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mArTb-0007rI-Ur; Tue, 03 Aug 2021 06:16:47 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:40235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mArTa-0005Ff-2g; Tue, 03 Aug 2021 06:16:47 -0400 Received: from [192.168.100.1] ([82.142.21.182]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MUokB-1mb5TG1a3V-00Qfzm; Tue, 03 Aug 2021 12:16:35 +0200 Subject: Re: [PATCH v6 0/2] target/s390x: Fix SIGILL and SIGFPE psw.addr reporting To: Cornelia Huck , Ilya Leoshkevich , Richard Henderson , David Hildenbrand References: <20210705210434.45824-1-iii@linux.ibm.com> <87pmuvymi0.fsf@redhat.com> From: Laurent Vivier Message-ID: Date: Tue, 3 Aug 2021 12:16:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87pmuvymi0.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:dBo93dqsJ08bNzsao3k3ynr+tVaer5RvD6ZdM6PBTsqPhzU1toS tJz8iFq6NJSiAfsRlNW3VpwY/214DEhmjiAJp9+QKk17gRkv2n87QANHkxT7In6iCa7ITku MEM2OBATgdgwo9MVmaAiJ8IVz7tl1vKmfP6lOWXYILeIhoer+KStJwSrCa/bqyiZwBWq0Is kqPsVCwyoiy+3km5i3VQA== X-UI-Out-Filterresults: notjunk:1;V03:K0:av1gOKdhcmE=:i4XXF/u7Zm96tWBTbPs0aR /Zkurt1LfZr8u9Tq6UPy8OGn0ovlzuNPVmuSVvFRsFa35ulcMichH32bfxG2wgVmxWKRBFjiz lscHZDHvReu+ydan0bmeD4CDYXG6KUDqSeTflYCO6k/EkGgE+tbOD5a5vYxuhTHQD+z8Z657L iK9KdbueYtoPcdgfUSc6lAu0rxLCZRYsCaLG4eWTMw/9okPMBDq7DuuCU10XlX8kKfXqzoptW XlHkCAWqEkitSJYVLrbTIZlR9orRIKziIEM8XlgWoK4xM2ZrTjB40+r6sXI/F3N1b/DY2JgwU nCp66y/4UPq3UwncFuUyOSU+6bKL8DuNpHC9NROGtTFIZJsbd2zNu40V+IcvYY6ZAvrJe4Bu0 rtJPzc4ACOT9pu3kmIS7fVaxDDzKrVfCFVsM/EdQRHxXcJu6uSww66EC8f86LSggPxXdvU4+a I1hnc0MUxOTr1YjATuvqGrdR2ZbGvfFNM9TuOYN2FUilYunjJcEG7uAUw8OMVsX133puXLVVk tw8zgb7MlkbMgqLil+MkDE7rNQdzUlicwn+7mf1ueJAyqyuFXYru5TpxbKg3SVa0w== Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jonathan . albrecht" , Ulrich Weigand , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Andreas Krebbel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 03/08/2021 à 10:13, Cornelia Huck a écrit : > On Mon, Jul 05 2021, Ilya Leoshkevich wrote: > >> qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it >> should be a pointer to the instruction following the illegal >> instruction, but at the moment it is a pointer to the illegal >> instruction itself. This breaks OpenJDK, which relies on this value. >> A similar problem exists for SIGFPE. >> >> Patch 1 fixes the issue, patch 2 adds a test. >> >> v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06592.html >> v1 -> v2: Use a better buglink (Cornelia), simplify the inline asm >> magic in the test and add an explanation (David). >> >> v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06649.html >> v2 -> v3: Fix SIGSEGV handling (found when trying to run valgrind under >> qemu-user). >> >> v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg00299.html >> v3 -> v4: Fix compiling the test on Ubuntu 20.04 (Jonathan). >> >> v4: https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg05848.html >> v4 -> v5: Greatly simplify the fix (Ulrich). >> >> v5: https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg06244.html >> v5 -> v6: Fix breakpoints (David). Add gdbstub test. >> >> Note: the compare-and-trap SIGFPE issue is being fixed separately. >> https://lists.nongnu.org/archive/html/qemu-devel/2021-06/msg05690.html >> >> Ilya Leoshkevich (2): >> target/s390x: Fix SIGILL and SIGFPE psw.addr reporting >> tests/tcg/s390x: Test SIGILL and SIGSEGV handling >> >> linux-user/s390x/cpu_loop.c | 12 +- >> tests/tcg/s390x/Makefile.target | 18 +- >> tests/tcg/s390x/gdbstub/test-signals-s390x.py | 76 ++++++++ >> tests/tcg/s390x/signals-s390x.c | 165 ++++++++++++++++++ >> 4 files changed, 269 insertions(+), 2 deletions(-) >> create mode 100644 tests/tcg/s390x/gdbstub/test-signals-s390x.py >> create mode 100644 tests/tcg/s390x/signals-s390x.c > > So, I'd like to see this merged, but I'm unsure on what we agreed -- I > thought this would go via linux-user. Do I misremember? > Please, take them via the s390x branch. Thanks, Laurent