From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1712FC0219B for ; Mon, 10 Feb 2025 14:43:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1thV0Q-0002Z8-Rz; Mon, 10 Feb 2025 09:43:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1thV0O-0002YO-Va for qemu-devel@nongnu.org; Mon, 10 Feb 2025 09:43:24 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1thV0N-00020g-AL for qemu-devel@nongnu.org; Mon, 10 Feb 2025 09:43:24 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-38de17a5fc9so429749f8f.3 for ; Mon, 10 Feb 2025 06:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739198600; x=1739803400; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hXmwefOaCUdbJ19sp/F/xIw1GIIfmYbZZnFNqirItMY=; b=PVoYdH3uGhfoJS4kG0PNX7Qt5txSnqD27jyC5kFju8IJLCIh8aSt/26AvVGCyLqq4i gUOPwyIuUewJ0083jSMNf/Q+S7MxtIn/ph3u6JvDUn+/cnt8ex4MmE1Xr07xfDbSsGqX pacAZDo5LyPgen62rpyke5IkhTusMr/nLoRveqt84fNk3MALot2PZkLqcFOs6h7vhZQ9 xg9b+bT1IBwXskZ9sVuhD1GDigazVtGaZ67aAzVVfI0r2YvA8tt6qXW/wZMEjaz5yMRc x7QA5uuVetW8uZejSW2yH/In3tDbksJcoa4iFqecsEXeD2g49uca4/7z81RdYJA0Q3qR aaPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739198600; x=1739803400; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hXmwefOaCUdbJ19sp/F/xIw1GIIfmYbZZnFNqirItMY=; b=cGIesYOnxOQiuq52Te7gwMzDbaKHtvTKt5y4ZVFux9QRdj9oCa0nWEXaqV0mhVGaqg 8IfV4DO56Y4KqDEOLxWcubqspThbxFIkUHvy8BIJfaawATZ/LRyH643i94v08yGYQg4I 3QOPjqC06HV9AODUr7KYGvp7F2ylqabEKaRF5l0ySjXP+fKVdMozFapVhlsKKJ58Fche 4AIYdCQtaSmXj3AlHsIrVqI4tpzv1K/JgZrP1tA9jBNgtvkC6D9P1h0diDukGWF+ccOd HIoavqAj5N7oEvbZRnzVlZeskrnADMWtD53tKOSL1z+tjkIn6XtTh+kKOuSqsph7uJbB +Ujg== X-Forwarded-Encrypted: i=1; AJvYcCVQv0GVDCDiEZqDO4myXLbF6W8Xes/1r1+19QPuJdQAEovHNYNek8W96+GJ6e3aTU2wEAapfz6R2kX0@nongnu.org X-Gm-Message-State: AOJu0YypmovOzc46wQKbpRB05tJ5SSvuz+inrPlzY0jF9oz3NSR8Ef7x arTIKnTwmCG/Ty3CLEcxzPd/xh1dFS/HwsJkdw5Ru4JXdEGp0y0PvYIfLOKAODs= X-Gm-Gg: ASbGncu6TynTR7xVvF9YQCfGAQvH94XLB6qPbJ4wkhGBzk3ZxvTFtVhNBV3KTsEZir/ 3ipza087R+o0MmcwmpDEc3kRAajZagOJM7yJv6+fkIGRR5dTbALjuV5t84Qv/TbYc6eMXKzNs/k Bg6VnREKvSglgTvdCmYEckZlWYub6nQ+Ob0s2K3V+n7ddWvw9AQBIA+0fmoqiiFVC6jVDKS1x56 08LZNDYKWAC/KSn/crPuxeDyaPhyxvp0Lw8VjG9KttariqTgtIgoGM2jzAmAHYyc9+lfjbcuPNu TRJFtwz2glkFX2augggwEaVoK/n7rfdv0KAhmLKLfoVq6RvYII2FT+7BXtk= X-Google-Smtp-Source: AGHT+IEmX869p1B+pc/NJPM1swf3AdxRQDGJFysTK+kTTmMaRA/VZdtPR75wxZ7so9UK0gYO6OrH7A== X-Received: by 2002:a5d:47ca:0:b0:38d:c557:1146 with SMTP id ffacd0b85a97d-38dc912339amr9143346f8f.20.1739198600407; Mon, 10 Feb 2025 06:43:20 -0800 (PST) Received: from [192.168.69.198] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43907f1b570sm154246085e9.1.2025.02.10.06.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 06:43:19 -0800 (PST) Message-ID: Date: Mon, 10 Feb 2025 15:43:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/17] hw/ssi: Make flash size a property in NPCM7XX FIU To: Hao Wu , peter.maydell@linaro.org Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, venture@google.com, Avi.Fishman@nuvoton.com, kfting@nuvoton.com, hskinnemoen@google.com, titusr@google.com, chli30@nuvoton.corp-partner.google.com, pbonzini@redhat.com, jasowang@redhat.com, alistair@alistair23.me References: <20250206221203.4187217-1-wuhaotsh@google.com> <20250206221203.4187217-4-wuhaotsh@google.com> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250206221203.4187217-4-wuhaotsh@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/2/25 23:11, Hao Wu wrote: > This allows different FIUs to have different flash sizes, useful > in NPCM8XX which has multiple different sized FIU modules. > > Reviewed-by: Peter Maydell > Signed-off-by: Hao Wu > --- > hw/arm/npcm7xx.c | 6 ++++++ > hw/ssi/npcm7xx_fiu.c | 16 ++++++++++++++-- > include/hw/ssi/npcm7xx_fiu.h | 1 + > 3 files changed, 21 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé