[PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss
@ 2024-01-02  2:01 Song Gao
  2024-01-02  2:02 ` [PATCH v2 2/2] target/loongarch: move translate modules to tcg/ Song Gao
  2024-01-02  9:46 ` [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss Philippe Mathieu-Daudé
  0 siblings, 2 replies; 5+ messages in thread
From: Song Gao @ 2024-01-02  2:01 UTC (permalink / raw)
  To: qemu-devel
  Cc: richard.henderson, peter.maydell, philmd, alex.bennee, pbonzini,
	maobibo

gdbstub.c is not specific to TCG and can be used by
other accelerators, such as KVM accelerator

Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Song Gao <gaosong@loongson.cn>
---
 target/loongarch/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/loongarch/meson.build b/target/loongarch/meson.build
index 18e8191e2b..b3a0fb12fb 100644
--- a/target/loongarch/meson.build
+++ b/target/loongarch/meson.build
@@ -3,6 +3,7 @@ gen = decodetree.process('insns.decode')
 loongarch_ss = ss.source_set()
 loongarch_ss.add(files(
   'cpu.c',
+  'gdbstub.c',
 ))
 loongarch_tcg_ss = ss.source_set()
 loongarch_tcg_ss.add(gen)
@@ -10,7 +11,6 @@ loongarch_tcg_ss.add(files(
   'fpu_helper.c',
   'op_helper.c',
   'translate.c',
-  'gdbstub.c',
   'vec_helper.c',
 ))
 loongarch_tcg_ss.add(zlib)
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] target/loongarch: move translate modules to tcg/
  2024-01-02  2:01 [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss Song Gao
@ 2024-01-02  2:02 ` Song Gao
  2024-01-02  9:45   ` Philippe Mathieu-Daudé
  2024-01-02  9:46 ` [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss Philippe Mathieu-Daudé
  1 sibling, 1 reply; 5+ messages in thread
From: Song Gao @ 2024-01-02  2:02 UTC (permalink / raw)
  To: qemu-devel
  Cc: richard.henderson, peter.maydell, philmd, alex.bennee, pbonzini,
	maobibo

Introduce the target/loongarch/tcg directory. Its purpose is to hold the TCG
code that is selected by CONFIG_TCG

Signed-off-by: Song Gao <gaosong@loongson.cn>
---
 target/loongarch/{ => tcg}/constant_timer.c   |  0
 target/loongarch/{ => tcg}/csr_helper.c       |  0
 target/loongarch/{ => tcg}/fpu_helper.c       |  0
 target/loongarch/{ => tcg}/iocsr_helper.c     |  0
 target/loongarch/{ => tcg}/op_helper.c        |  0
 target/loongarch/{ => tcg}/tlb_helper.c       |  0
 target/loongarch/{ => tcg}/translate.c        |  0
 target/loongarch/{ => tcg}/vec_helper.c       |  0
 .../{ => tcg}/insn_trans/trans_arith.c.inc    |  0
 .../{ => tcg}/insn_trans/trans_atomic.c.inc   |  0
 .../{ => tcg}/insn_trans/trans_bit.c.inc      |  0
 .../{ => tcg}/insn_trans/trans_branch.c.inc   |  0
 .../{ => tcg}/insn_trans/trans_extra.c.inc    |  0
 .../{ => tcg}/insn_trans/trans_farith.c.inc   |  0
 .../{ => tcg}/insn_trans/trans_fcmp.c.inc     |  0
 .../{ => tcg}/insn_trans/trans_fcnv.c.inc     |  0
 .../{ => tcg}/insn_trans/trans_fmemory.c.inc  |  0
 .../{ => tcg}/insn_trans/trans_fmov.c.inc     |  0
 .../{ => tcg}/insn_trans/trans_memory.c.inc   |  0
 .../insn_trans/trans_privileged.c.inc         |  0
 .../{ => tcg}/insn_trans/trans_shift.c.inc    |  0
 .../{ => tcg}/insn_trans/trans_vec.c.inc      |  0
 target/loongarch/meson.build                  | 15 +--------------
 target/loongarch/tcg/meson.build              | 19 +++++++++++++++++++
 24 files changed, 20 insertions(+), 14 deletions(-)
 rename target/loongarch/{ => tcg}/constant_timer.c (100%)
 rename target/loongarch/{ => tcg}/csr_helper.c (100%)
 rename target/loongarch/{ => tcg}/fpu_helper.c (100%)
 rename target/loongarch/{ => tcg}/iocsr_helper.c (100%)
 rename target/loongarch/{ => tcg}/op_helper.c (100%)
 rename target/loongarch/{ => tcg}/tlb_helper.c (100%)
 rename target/loongarch/{ => tcg}/translate.c (100%)
 rename target/loongarch/{ => tcg}/vec_helper.c (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_arith.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_atomic.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_bit.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_branch.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_extra.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_farith.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_fcmp.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_fcnv.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_fmemory.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_fmov.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_memory.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_privileged.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_shift.c.inc (100%)
 rename target/loongarch/{ => tcg}/insn_trans/trans_vec.c.inc (100%)
 create mode 100644 target/loongarch/tcg/meson.build

diff --git a/target/loongarch/constant_timer.c b/target/loongarch/tcg/constant_timer.c
similarity index 100%
rename from target/loongarch/constant_timer.c
rename to target/loongarch/tcg/constant_timer.c
diff --git a/target/loongarch/csr_helper.c b/target/loongarch/tcg/csr_helper.c
similarity index 100%
rename from target/loongarch/csr_helper.c
rename to target/loongarch/tcg/csr_helper.c
diff --git a/target/loongarch/fpu_helper.c b/target/loongarch/tcg/fpu_helper.c
similarity index 100%
rename from target/loongarch/fpu_helper.c
rename to target/loongarch/tcg/fpu_helper.c
diff --git a/target/loongarch/iocsr_helper.c b/target/loongarch/tcg/iocsr_helper.c
similarity index 100%
rename from target/loongarch/iocsr_helper.c
rename to target/loongarch/tcg/iocsr_helper.c
diff --git a/target/loongarch/op_helper.c b/target/loongarch/tcg/op_helper.c
similarity index 100%
rename from target/loongarch/op_helper.c
rename to target/loongarch/tcg/op_helper.c
diff --git a/target/loongarch/tlb_helper.c b/target/loongarch/tcg/tlb_helper.c
similarity index 100%
rename from target/loongarch/tlb_helper.c
rename to target/loongarch/tcg/tlb_helper.c
diff --git a/target/loongarch/translate.c b/target/loongarch/tcg/translate.c
similarity index 100%
rename from target/loongarch/translate.c
rename to target/loongarch/tcg/translate.c
diff --git a/target/loongarch/vec_helper.c b/target/loongarch/tcg/vec_helper.c
similarity index 100%
rename from target/loongarch/vec_helper.c
rename to target/loongarch/tcg/vec_helper.c
diff --git a/target/loongarch/insn_trans/trans_arith.c.inc b/target/loongarch/tcg/insn_trans/trans_arith.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_arith.c.inc
rename to target/loongarch/tcg/insn_trans/trans_arith.c.inc
diff --git a/target/loongarch/insn_trans/trans_atomic.c.inc b/target/loongarch/tcg/insn_trans/trans_atomic.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_atomic.c.inc
rename to target/loongarch/tcg/insn_trans/trans_atomic.c.inc
diff --git a/target/loongarch/insn_trans/trans_bit.c.inc b/target/loongarch/tcg/insn_trans/trans_bit.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_bit.c.inc
rename to target/loongarch/tcg/insn_trans/trans_bit.c.inc
diff --git a/target/loongarch/insn_trans/trans_branch.c.inc b/target/loongarch/tcg/insn_trans/trans_branch.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_branch.c.inc
rename to target/loongarch/tcg/insn_trans/trans_branch.c.inc
diff --git a/target/loongarch/insn_trans/trans_extra.c.inc b/target/loongarch/tcg/insn_trans/trans_extra.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_extra.c.inc
rename to target/loongarch/tcg/insn_trans/trans_extra.c.inc
diff --git a/target/loongarch/insn_trans/trans_farith.c.inc b/target/loongarch/tcg/insn_trans/trans_farith.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_farith.c.inc
rename to target/loongarch/tcg/insn_trans/trans_farith.c.inc
diff --git a/target/loongarch/insn_trans/trans_fcmp.c.inc b/target/loongarch/tcg/insn_trans/trans_fcmp.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_fcmp.c.inc
rename to target/loongarch/tcg/insn_trans/trans_fcmp.c.inc
diff --git a/target/loongarch/insn_trans/trans_fcnv.c.inc b/target/loongarch/tcg/insn_trans/trans_fcnv.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_fcnv.c.inc
rename to target/loongarch/tcg/insn_trans/trans_fcnv.c.inc
diff --git a/target/loongarch/insn_trans/trans_fmemory.c.inc b/target/loongarch/tcg/insn_trans/trans_fmemory.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_fmemory.c.inc
rename to target/loongarch/tcg/insn_trans/trans_fmemory.c.inc
diff --git a/target/loongarch/insn_trans/trans_fmov.c.inc b/target/loongarch/tcg/insn_trans/trans_fmov.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_fmov.c.inc
rename to target/loongarch/tcg/insn_trans/trans_fmov.c.inc
diff --git a/target/loongarch/insn_trans/trans_memory.c.inc b/target/loongarch/tcg/insn_trans/trans_memory.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_memory.c.inc
rename to target/loongarch/tcg/insn_trans/trans_memory.c.inc
diff --git a/target/loongarch/insn_trans/trans_privileged.c.inc b/target/loongarch/tcg/insn_trans/trans_privileged.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_privileged.c.inc
rename to target/loongarch/tcg/insn_trans/trans_privileged.c.inc
diff --git a/target/loongarch/insn_trans/trans_shift.c.inc b/target/loongarch/tcg/insn_trans/trans_shift.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_shift.c.inc
rename to target/loongarch/tcg/insn_trans/trans_shift.c.inc
diff --git a/target/loongarch/insn_trans/trans_vec.c.inc b/target/loongarch/tcg/insn_trans/trans_vec.c.inc
similarity index 100%
rename from target/loongarch/insn_trans/trans_vec.c.inc
rename to target/loongarch/tcg/insn_trans/trans_vec.c.inc
diff --git a/target/loongarch/meson.build b/target/loongarch/meson.build
index b3a0fb12fb..e84e4c51f4 100644
--- a/target/loongarch/meson.build
+++ b/target/loongarch/meson.build
@@ -5,29 +5,16 @@ loongarch_ss.add(files(
   'cpu.c',
   'gdbstub.c',
 ))
-loongarch_tcg_ss = ss.source_set()
-loongarch_tcg_ss.add(gen)
-loongarch_tcg_ss.add(files(
-  'fpu_helper.c',
-  'op_helper.c',
-  'translate.c',
-  'vec_helper.c',
-))
-loongarch_tcg_ss.add(zlib)
 
 loongarch_system_ss = ss.source_set()
 loongarch_system_ss.add(files(
   'loongarch-qmp-cmds.c',
   'machine.c',
-  'tlb_helper.c',
-  'constant_timer.c',
-  'csr_helper.c',
-  'iocsr_helper.c',
 ))
 
 common_ss.add(when: 'CONFIG_LOONGARCH_DIS', if_true: [files('disas.c'), gen])
 
-loongarch_ss.add_all(when: 'CONFIG_TCG', if_true: [loongarch_tcg_ss])
+subdir('tcg')
 
 target_arch += {'loongarch': loongarch_ss}
 target_system_arch += {'loongarch': loongarch_system_ss}
diff --git a/target/loongarch/tcg/meson.build b/target/loongarch/tcg/meson.build
new file mode 100644
index 0000000000..1a3cd589fb
--- /dev/null
+++ b/target/loongarch/tcg/meson.build
@@ -0,0 +1,19 @@
+if 'CONFIG_TCG' not in config_all
+  subdir_done()
+endif
+
+loongarch_ss.add([zlib, gen])
+
+loongarch_ss.add(files(
+  'fpu_helper.c',
+  'op_helper.c',
+  'translate.c',
+  'vec_helper.c',
+))
+
+loongarch_system_ss.add(files(
+  'constant_timer.c',
+  'csr_helper.c',
+  'iocsr_helper.c',
+  'tlb_helper.c',
+))
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] target/loongarch: move translate modules to tcg/
  2024-01-02  2:02 ` [PATCH v2 2/2] target/loongarch: move translate modules to tcg/ Song Gao
@ 2024-01-02  9:45   ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-01-02  9:45 UTC (permalink / raw)
  To: Song Gao, qemu-devel
  Cc: richard.henderson, peter.maydell, alex.bennee, pbonzini, maobibo

On 2/1/24 03:02, Song Gao wrote:
> Introduce the target/loongarch/tcg directory. Its purpose is to hold the TCG
> code that is selected by CONFIG_TCG
> 
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   target/loongarch/{ => tcg}/constant_timer.c   |  0
>   target/loongarch/{ => tcg}/csr_helper.c       |  0
>   target/loongarch/{ => tcg}/fpu_helper.c       |  0
>   target/loongarch/{ => tcg}/iocsr_helper.c     |  0
>   target/loongarch/{ => tcg}/op_helper.c        |  0
>   target/loongarch/{ => tcg}/tlb_helper.c       |  0
>   target/loongarch/{ => tcg}/translate.c        |  0
>   target/loongarch/{ => tcg}/vec_helper.c       |  0
>   .../{ => tcg}/insn_trans/trans_arith.c.inc    |  0
>   .../{ => tcg}/insn_trans/trans_atomic.c.inc   |  0
>   .../{ => tcg}/insn_trans/trans_bit.c.inc      |  0
>   .../{ => tcg}/insn_trans/trans_branch.c.inc   |  0
>   .../{ => tcg}/insn_trans/trans_extra.c.inc    |  0
>   .../{ => tcg}/insn_trans/trans_farith.c.inc   |  0
>   .../{ => tcg}/insn_trans/trans_fcmp.c.inc     |  0
>   .../{ => tcg}/insn_trans/trans_fcnv.c.inc     |  0
>   .../{ => tcg}/insn_trans/trans_fmemory.c.inc  |  0
>   .../{ => tcg}/insn_trans/trans_fmov.c.inc     |  0
>   .../{ => tcg}/insn_trans/trans_memory.c.inc   |  0
>   .../insn_trans/trans_privileged.c.inc         |  0
>   .../{ => tcg}/insn_trans/trans_shift.c.inc    |  0
>   .../{ => tcg}/insn_trans/trans_vec.c.inc      |  0
>   target/loongarch/meson.build                  | 15 +--------------
>   target/loongarch/tcg/meson.build              | 19 +++++++++++++++++++
>   24 files changed, 20 insertions(+), 14 deletions(-)

>   create mode 100644 target/loongarch/tcg/meson.build
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss
  2024-01-02  2:01 [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss Song Gao
  2024-01-02  2:02 ` [PATCH v2 2/2] target/loongarch: move translate modules to tcg/ Song Gao
@ 2024-01-02  9:46 ` Philippe Mathieu-Daudé
  2024-01-02 12:05   ` gaosong
  1 sibling, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-01-02  9:46 UTC (permalink / raw)
  To: Song Gao, qemu-devel
  Cc: richard.henderson, peter.maydell, alex.bennee, pbonzini, maobibo

On 2/1/24 03:01, Song Gao wrote:
> gdbstub.c is not specific to TCG and can be used by
> other accelerators, such as KVM accelerator
> 
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

I didn't really suggested the change but the split ;)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   target/loongarch/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss
  2024-01-02  9:46 ` [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss Philippe Mathieu-Daudé
@ 2024-01-02 12:05   ` gaosong
  0 siblings, 0 replies; 5+ messages in thread
From: gaosong @ 2024-01-02 12:05 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: richard.henderson, peter.maydell, alex.bennee, pbonzini, maobibo

在 2024/1/2 下午5:46, Philippe Mathieu-Daudé 写道:
> On 2/1/24 03:01, Song Gao wrote:
>> gdbstub.c is not specific to TCG and can be used by
>> other accelerators, such as KVM accelerator
>>
>> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> I didn't really suggested the change but the split ;)
>
Ah,  I can drop it for pull request.

Thanks.
Song Gao.
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
>> Signed-off-by: Song Gao <gaosong@loongson.cn>
>> ---
>>   target/loongarch/meson.build | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-02 12:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-02  2:01 [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss Song Gao
2024-01-02  2:02 ` [PATCH v2 2/2] target/loongarch: move translate modules to tcg/ Song Gao
2024-01-02  9:45   ` Philippe Mathieu-Daudé
2024-01-02  9:46 ` [PATCH v2 1/2] target/loongarch/meson: move gdbstub.c to loongarch.ss Philippe Mathieu-Daudé
2024-01-02 12:05   ` gaosong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).