From: "Cédric Le Goater" <clg@kaod.org>
To: Nabih Estefan <nabihestefan@google.com>,
Kane Chen <kane_chen@aspeedtech.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Steven Lee <steven_lee@aspeedtech.com>,
Troy Lee <leetroy@gmail.com>,
Jamin Lin <jamin_lin@aspeedtech.com>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
<troy_lee@aspeedtech.com>, Joe Komlodi <komlodi@google.com>
Subject: Re: [PATCH v3 18/18] hw/arm/aspeed: Model AST1700 I3C block as unimplemented device
Date: Tue, 9 Dec 2025 09:51:45 +0100 [thread overview]
Message-ID: <c20c67df-6099-4a59-bb5f-dff6d925aa2a@kaod.org> (raw)
In-Reply-To: <CA+QoejU-hpaBce7KoOA0PXBz+DVT1-ZvoyY=mgDPnZLbdZwdHQ@mail.gmail.com>
On 12/8/25 19:23, Nabih Estefan wrote:
> On Sun, Dec 7, 2025 at 11:47 PM Kane Chen via <qemu-devel@nongnu.org> wrote:
>>
>> From: Kane-Chen-AS <kane_chen@aspeedtech.com>
>>
>> AST1700 exposes more I3C buses than the current dummy I3C model
>> provides. When Linux probes the I3C devices on AST1700 this mismatch
>> can trigger a kernel panic. Model the I3C block as an unimplemented
>> device to make the missing functionality explicit and avoid unexpected
>> side effects.
>>
>> This wires up the I3C interrupt lines for the IO expanders and adds the
>> corresponding device entries for the AST1700 model.
>>
>> No functional I3C emulation is provided yet; this only prevents crashes and
>> documents the missing piece.
>
> Would you be able to help review Joe Komlodi's I3C support patchset
> (link below)?
> I think it probably fills in this gap.
yes. I have been keeping Joe's series in my tree for a while now.
It looks saneand it would be great if someone could dedicate
some time to the review.
Can we make this a target for QEMU 11.0 ?
Thanks,
C.
next prev parent reply other threads:[~2025-12-09 8:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 7:44 [PATCH v3 00/18] hw/arm/aspeed: AST1700 LTPI support and device hookups Kane Chen via
2025-12-08 7:44 ` [PATCH v3 01/18] hw/misc: Add LTPI controller Kane Chen via
2025-12-10 23:00 ` Nabih Estefan
2025-12-08 7:44 ` [PATCH v3 02/18] hw/arm/aspeed: Attach LTPI controller to AST27X0 platform Kane Chen via
2025-12-10 23:00 ` Nabih Estefan
2025-12-08 7:44 ` [PATCH v3 03/18] hw/misc: Add basic Aspeed PWM model Kane Chen via
2025-12-10 23:00 ` Nabih Estefan
2025-12-08 7:44 ` [PATCH v3 04/18] hw/arm/aspeed: Add AST1700 LTPI expander device model Kane Chen via
2025-12-08 7:44 ` [PATCH v3 05/18] hw/arm/aspeed: Integrate AST1700 device into AST27X0 Kane Chen via
2025-12-08 7:44 ` [PATCH v3 06/18] hw/arm/aspeed: Integrate interrupt controller for AST1700 Kane Chen via
2025-12-08 21:03 ` Nabih Estefan
2025-12-09 2:08 ` Kane Chen
2025-12-09 8:47 ` Cédric Le Goater
2025-12-08 7:44 ` [PATCH v3 07/18] hw/arm/aspeed: Attach LTPI controller to AST1700 model Kane Chen via
2025-12-08 7:44 ` [PATCH v3 08/18] hw/arm/aspeed: Attach UART device " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 09/18] hw/arm/aspeed: Attach SRAM " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 10/18] hw/arm/aspeed: Attach SPI " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 11/18] hw/arm/aspeed: Attach ADC " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 12/18] hw/arm/aspeed: Attach SCU " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 13/18] hw/arm/aspeed: Attach GPIO " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 14/18] hw/arm/aspeed: attach I2C " Kane Chen via
2025-12-10 23:01 ` Nabih Estefan
2025-12-08 7:44 ` [PATCH v3 15/18] hw/arm/aspeed: Attach WDT " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 16/18] hw/arm/aspeed: Attach PWM " Kane Chen via
2025-12-08 7:44 ` [PATCH v3 17/18] hw/arm/aspeed: Attach SGPIOM " Kane Chen via
2025-12-08 18:21 ` Nabih Estefan
2025-12-09 8:49 ` Cédric Le Goater
2025-12-09 10:17 ` Kane Chen
2025-12-10 2:41 ` Jamin Lin
2025-12-08 7:44 ` [PATCH v3 18/18] hw/arm/aspeed: Model AST1700 I3C block as unimplemented device Kane Chen via
2025-12-08 18:23 ` Nabih Estefan
2025-12-09 8:51 ` Cédric Le Goater [this message]
2025-12-10 23:01 ` [PATCH v3 00/18] hw/arm/aspeed: AST1700 LTPI support and device hookups Nabih Estefan
2025-12-11 6:42 ` Kane Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c20c67df-6099-4a59-bb5f-dff6d925aa2a@kaod.org \
--to=clg@kaod.org \
--cc=andrew@codeconstruct.com.au \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=komlodi@google.com \
--cc=leetroy@gmail.com \
--cc=nabihestefan@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).