From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
Qemu-block <qemu-block@nongnu.org>,
"Kevin Wolf" <kwolf@redhat.com>
Subject: Re: [PATCH v2 05/11] tests/lcitool: add nettle to the minimal deps
Date: Mon, 8 Dec 2025 10:17:24 +0100 [thread overview]
Message-ID: <c212c31b-e927-4083-a3a9-977625a3d30d@redhat.com> (raw)
In-Reply-To: <aTaWTJTWcAXO11Mc@redhat.com>
On 08/12/2025 10.11, Daniel P. Berrangé wrote:
> On Fri, Dec 05, 2025 at 12:48:25PM +0000, Alex Bennée wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>>
>>> On 04/12/2025 20.48, Alex Bennée wrote:
>>>> Technically we don't need a crypto library to do the base build but
>>>> I couldn't see an easy way to skip iotests which would otherwise fail.
>>>> Besides libnettle is a fairly small library even if its not the
>>>> fastest crypto implementation.
>>>
>>> I think we added checks to some of the iotests in the past already to
>>> skip if the crypto stuff is not available? So I think it might be
>>> better to fix the related iotests instead.
>
> We have _require_working_luks called by "_supported_fmt luks"
> in the shell tests, and iotests.verify_working_luks called
> in the python tests. Possibly we didn't call them in all the
> required places ? Or there is a non-luks related test that
> uses crypto we missed ?
It's about non-luks related tests, see the patch here:
https://lore.kernel.org/qemu-devel/6333f8d4-3feb-43c7-8d11-98a7c3cbe0c4@redhat.com/T/#t
Thomas
next prev parent reply other threads:[~2025-12-08 9:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 19:48 [PATCH v2 00/11] Final fixes for 10.2 (build, docs, dockerfiles, plugins) Alex Bennée
2025-12-04 19:48 ` [PATCH v2 01/11] gitlab: drop --disable-pie from aarch64-all-linux-static build Alex Bennée
2025-12-05 7:53 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 02/11] gitlab: drop explicit pxe-test from the build-tci job Alex Bennée
2025-12-05 7:54 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 03/11] tests/tcg: honour the available QEMU binaries when running check-tcg Alex Bennée
2025-12-04 19:48 ` [PATCH v2 04/11] tests/lcitool: add bzip2 to the minimal dependency list Alex Bennée
2025-12-05 6:14 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 05/11] tests/lcitool: add nettle to the minimal deps Alex Bennée
2025-12-05 6:37 ` Thomas Huth
2025-12-05 12:48 ` Alex Bennée
2025-12-08 9:11 ` Daniel P. Berrangé
2025-12-08 9:17 ` Thomas Huth [this message]
2025-12-04 19:48 ` [PATCH v2 06/11] tests/docker: transition debian-all-test-cross to lcitool Alex Bennée
2025-12-04 19:48 ` [PATCH v2 07/11] tests/docker: drop --disable-[tools|system] from all-test-cross Alex Bennée
2025-12-05 6:40 ` Thomas Huth
2025-12-04 19:48 ` [PATCH v2 08/11] docs/devel: update build environment setup documentation Alex Bennée
2025-12-04 19:49 ` [PATCH v2 09/11] docs/devel: Correct typo Alex Bennée
2025-12-08 9:21 ` Philippe Mathieu-Daudé
2025-12-04 19:49 ` [PATCH v2 10/11] MAINTAINERS: update the custom runner entries Alex Bennée
2025-12-05 6:09 ` Thomas Huth
2025-12-08 9:20 ` Philippe Mathieu-Daudé
2025-12-04 19:49 ` [PATCH v2 11/11] plugins/core: allow reading of registers during discon events Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c212c31b-e927-4083-a3a9-977625a3d30d@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=erdnaxe@crans.org \
--cc=kwolf@redhat.com \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).