From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBB1CA90AF for ; Wed, 13 May 2020 12:20:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3426920769 for ; Wed, 13 May 2020 12:20:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HbbLUp17" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3426920769 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYqN3-0007vm-A8 for qemu-devel@archiver.kernel.org; Wed, 13 May 2020 08:20:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYqHJ-0004iw-6O for qemu-devel@nongnu.org; Wed, 13 May 2020 08:14:25 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20057 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYqHH-0001GQ-Iy for qemu-devel@nongnu.org; Wed, 13 May 2020 08:14:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589372061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=a60t2++1erjwPY7X5QLmKQ29d+3fMFkawizGvmkYpMQ=; b=HbbLUp17dgcNX1gbTi8p4HRx2nAn/HyFQyqHkQcJBlo4UE+b6yUvqJb4IoU4tGFJKa62o8 TZyuBU/9NU8ryG57oRyiYKDNQtuFEfbTFUX+TGGw3Z6JN2sY4WTIP4P0GHzhEQcutw6zfx kTixHdqMDye97ekGx8jGh1dHv84vobE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-CBhi_S1HP-KaalDp_ln2vQ-1; Wed, 13 May 2020 08:14:19 -0400 X-MC-Unique: CBhi_S1HP-KaalDp_ln2vQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2AB580B724; Wed, 13 May 2020 12:14:18 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.193.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 993E21000079; Wed, 13 May 2020 12:14:17 +0000 (UTC) Subject: Re: [PATCH 2/2] iotests: Run pylint and mypy in a testcase To: Kevin Wolf , qemu-block@nongnu.org References: <20200511163529.349329-1-kwolf@redhat.com> <20200511163529.349329-3-kwolf@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Wed, 13 May 2020 14:14:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200511163529.349329-3-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0fZc8NekEVVxhQsdkNEO0EXdmeNqCTDcx" Received-SPF: pass client-ip=207.211.31.81; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 04:17:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jsnow@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0fZc8NekEVVxhQsdkNEO0EXdmeNqCTDcx Content-Type: multipart/mixed; boundary="s2YoBVCXorb2tQkTONhxGRdVNW1XZpWOm" --s2YoBVCXorb2tQkTONhxGRdVNW1XZpWOm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11.05.20 18:35, Kevin Wolf wrote: > We made sure that iotests.py passes pylint. It would be a shame if we > allowed new patches in that break this again, so let's just add a > meta-test case that runs pylint on it. >=20 > While we don't pass mypy --strict yet, we can already run it with a few > options that would be part of --strict to make sure that we won't > regress on these aspects at least until we can enable the full thing. >=20 > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/297 | 44 ++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/297.out | 3 +++ > tests/qemu-iotests/group | 1 + > 3 files changed, 48 insertions(+) > create mode 100755 tests/qemu-iotests/297 > create mode 100644 tests/qemu-iotests/297.out Bit of a shame that this takes 8 s (on my machine at least) and will run with every format/protocol combination unless I explictly exclude it with -x meta... But I suppose the actual problem here is the fact that tests still can=E2=80=99t just define a =E2=80=9CThis is the format/protoco= l combination I require=E2=80=9D and then you can just let all tests run once with that default combination. (And maybe afterwards run all tests again with some custom combinations, but only when that makes sense.) Well. Not a new problem. Reviewed-by: Max Reitz --s2YoBVCXorb2tQkTONhxGRdVNW1XZpWOm-- --0fZc8NekEVVxhQsdkNEO0EXdmeNqCTDcx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl675JcACgkQ9AfbAGHV z0AkYAgAqQRpWStpKXpmIbeBezHBuTjiNLTI4hWd4IGI44NQ/l4uvicPFh1Znknx j0WUyk5EjJNBXzxrYHOrXPBLCLNHGdT93o6bFPrOKET1gSgMio6KYVZf6WtyFj4I UTBfl/8mtyl5VFb3a+4V4WHLvd/5Wx/Uq0pKUiNbpRqPdOZ29P5GVyl5+Zi0rsyh YqzyD76Gxtbtdi9YUNL9n9UZrNcHCqfi7E2lUHviWsv+z5qO+bURB/Ce2NSe1QF/ 0zSPvMh5nlNgppaAsEYz7e0yuBSnghy73Ao4vtgNmUmHLxCDcGujfNOE+NkFhpkT Fyufa7hgXg/Lc6N+BTLBeDk1yfnwvQ== =WHaq -----END PGP SIGNATURE----- --0fZc8NekEVVxhQsdkNEO0EXdmeNqCTDcx--