Re: [Qemu-devel] [Qemu-block] [PATCH 1/9] block: Add COR filter driver

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On 2018-04-20 10:31, Stefan Hajnoczi wrote:
> On Mon, Apr 16, 2018 at 06:58:41PM +0200, Max Reitz wrote:
>>  { 'enum': 'BlockdevDriver',
>> -  'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop',
>> +  'data': [ 'blkdebug', 'blkverify', 'bochs', 'cloop', 'cor',
> 
> "copy-on-read" would be clearer than "cor" for the QMP API and the
> block/cor.c source file.  Is there a need to make the name very short?

There definitely is no need.  I decided I'd prefer to type less in the
test cases, so I went for the shorter name.  (I thought blockdev-add was
sufficiently verbose as it is.)

But I don't mind un-abbreviating it either.  (Probably better
considering that blockdev-add is already verbose, so there is no point
in making parts of it artificially dense.)


Thanks for reviewing!

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]