From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Jason Wang" <jasowang@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Michele Denber" <denber@mindspring.com>
Subject: Re: [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro
Date: Sat, 4 Jul 2020 19:11:24 +0200 [thread overview]
Message-ID: <c247fc94-f8f7-efe1-017f-fc1c03fee811@redhat.com> (raw)
In-Reply-To: <20200704092317.12943-1-peter.maydell@linaro.org>
On 04/07/2020 11.23, Peter Maydell wrote:
> In commit a8d2532645cf5ce4 we cleaned up usage of the qemu-common.h header
> so that it was always included from .c files and never from other .h files.
> We missed adding it to net/tap-solaris.c (which previously was pulling it
> in via tap-int.h), which broke building on Solaris hosts.
>
> Fixes: a8d2532645cf5ce4
> Reported-by: Michele Denber <denber@mindspring.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Untested: Michele, could you give this a try?
> ---
> net/tap-solaris.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/tap-solaris.c b/net/tap-solaris.c
> index 4725d2314ee..d03165c57c9 100644
> --- a/net/tap-solaris.c
> +++ b/net/tap-solaris.c
> @@ -27,6 +27,7 @@
> #include "tap_int.h"
> #include "qemu/ctype.h"
> #include "qemu/cutils.h"
> +#include "qemu-common.h"
>
> #include <sys/ethernet.h>
> #include <sys/sockio.h>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-07-04 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 9:23 [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro Peter Maydell
2020-07-04 10:34 ` Philippe Mathieu-Daudé
2020-07-04 17:11 ` Thomas Huth [this message]
2020-07-04 18:13 ` Michele Denber
2020-07-06 17:04 ` Laurent Vivier
2020-07-06 17:56 ` Philippe Mathieu-Daudé
2020-07-06 19:30 ` Laurent Vivier
2020-07-07 15:23 ` Michele Denber
2020-07-07 16:18 ` Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2020-10-12 15:33 [PATCH 00/10] target/arm: Various v8.1M minor features Peter Maydell
2020-10-12 15:33 ` [PATCH] net/tap-solaris.c: Include qemu-common.h for TFR macro Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c247fc94-f8f7-efe1-017f-fc1c03fee811@redhat.com \
--to=thuth@redhat.com \
--cc=denber@mindspring.com \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).