Re: [PATCH v2 14/15] disas: Remove CRIS disassembler

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 5/9/24 03:30, Richard Henderson wrote:
> On 9/4/24 07:36, Philippe Mathieu-Daudé wrote:
>> --- a/include/disas/dis-asm.h
>> +++ b/include/disas/dis-asm.h
>> @@ -232,10 +232,6 @@ enum bfd_architecture
>>   #define bfd_mach_avrxmega5  105
>>   #define bfd_mach_avrxmega6  106
>>   #define bfd_mach_avrxmega7  107
>> -  bfd_arch_cris,       /* Axis CRIS */
>> -#define bfd_mach_cris_v0_v10   255
>> -#define bfd_mach_cris_v32      32
>> -#define bfd_mach_cris_v10_v32  1032
>>     bfd_arch_microblaze, /* Xilinx MicroBlaze.  */
>>     bfd_arch_moxie,      /* The Moxie core.  */
>>     bfd_arch_ia64,      /* HP/Intel ia64 */
>> @@ -448,8 +444,6 @@ int print_insn_w65              (bfd_vma, 
>> disassemble_info*);
>>  int print_insn_d10v             (bfd_vma, disassemble_info*);
>>  int print_insn_v850             (bfd_vma, disassemble_info*);
>>  int print_insn_tic30            (bfd_vma, disassemble_info*);
>> -int print_insn_crisv32          (bfd_vma, disassemble_info*);
>> -int print_insn_crisv10          (bfd_vma, disassemble_info*);
>>  int print_insn_microblaze       (bfd_vma, disassemble_info*);
>>  int print_insn_ia64             (bfd_vma, disassemble_info*);
>>  int print_insn_xtensa           (bfd_vma, disassemble_info*);
> 
> 
> This is probably worth leaving alone, since it's all imported.
> There is lots of other stuff in there (even in these hunks)
> that is not relevant to qemu.

This is no more an import, see addition in commit
aae1746c72 ("target/loongarch: Add disassembler")
and removals in 9992f57978..333f944c15 6c3014858c:

. 6c3014858c target/nios2: Remove the deprecated Nios II target
. 9992f57978 disas: Remove old libopcode s390 disassembler
. 333f944c15 disas: Remove old libopcode ppc disassembler
. 457248a54c disas: Remove old libopcode i386 disassembler
. 82f96346e1 disas: Remove old libopcode arm disassembler

I don't mind discarding this patch, but I'd like to know
how we can be consistent with this file and the future
removals.

Thanks,

Phil.