From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-riscv@nongnu.org, qemu-ppc@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH-for-10.0 1/3] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state
Date: Tue, 4 Feb 2025 07:59:38 +0100 [thread overview]
Message-ID: <c26294a7-22db-4255-8886-c7973471feae@redhat.com> (raw)
In-Reply-To: <20241125181420.24424-2-philmd@linaro.org>
On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote:
> MachineClass::no_sdcard is initialized as false by default.
> To catch all uses, convert it to a tri-state, having the
> current default (false) becoming AUTO.
>
> No logical change intended.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/boards.h | 2 +-
> hw/arm/xilinx_zynq.c | 2 +-
> hw/core/null-machine.c | 2 +-
> hw/s390x/s390-virtio-ccw.c | 2 +-
> system/vl.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-02-04 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 18:14 [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag Philippe Mathieu-Daudé
2024-11-25 18:14 ` [PATCH-for-10.0 1/3] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state Philippe Mathieu-Daudé
2025-02-04 6:59 ` Thomas Huth [this message]
2024-11-25 18:14 ` [PATCH-for-10.0 2/3] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF Philippe Mathieu-Daudé
2025-02-04 7:00 ` Thomas Huth
2024-11-25 18:14 ` [PATCH-for-10.0 3/3] hw/boards: Rename no_sdcard -> create_default_sdcard_drive Philippe Mathieu-Daudé
2025-02-04 7:07 ` Thomas Huth
2025-02-04 11:09 ` Philippe Mathieu-Daudé
2024-11-26 5:24 ` [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag Philippe Mathieu-Daudé
2025-02-04 7:11 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c26294a7-22db-4255-8886-c7973471feae@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).