From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, yang.zhong@intel.com
Cc: qemu-ppc@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>
Subject: Re: [Qemu-devel] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
Date: Wed, 30 Jan 2019 11:25:13 +0100 [thread overview]
Message-ID: <c26ebf71-70e5-4162-6039-4d13654c780c@redhat.com> (raw)
In-Reply-To: <1dfe0b1f-a59a-db8a-ef1e-81cb24166c24@redhat.com>
On 2019-01-30 11:17, Paolo Bonzini wrote:
> On 30/01/19 10:43, Thomas Huth wrote:
>> + select LSI_SCSI_PCI
>
> Should NE2000_ISA and LSI_SCSI_PCI be handled the same? Either rely on
> "default y" for both, or select both (I think I prefer the former).
Yes. IMHO we should use "select XXX" if the machine has a hard
requirement for a device, and "default y" if it can also somehow work
without the device. In this case, I did not look carefully enough, since
it is apparently possible to use the 40p machine also without the LSI
controller when you specify "-nodefaults". So I'll remove this in v2 and
rely on the "default y" instead.
Thomas
next prev parent reply other threads:[~2019-01-30 10:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3f01a301-d639-dbe7-f522-42a50e2d443e@redhat.com>
2019-01-28 15:29 ` [Qemu-devel] [PATCH] s390x: express dependencies with Kconfig Thomas Huth
2019-01-28 16:08 ` [Qemu-devel] [qemu-s390x] " Cornelia Huck
2019-01-29 9:08 ` Thomas Huth
2019-01-29 9:42 ` [Qemu-devel] [PATCH v2] " Thomas Huth
2019-01-29 9:49 ` [Qemu-devel] [qemu-s390x] " Cornelia Huck
2019-01-29 10:07 ` Paolo Bonzini
2019-01-29 11:02 ` Yang Zhong
2019-01-30 9:43 ` [Qemu-devel] [RFC PATCH 0/5] Kconfig dependencies for ppc machines Thomas Huth
2019-01-30 9:43 ` [Qemu-devel] [RFC PATCH 1/5] ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig Thomas Huth
2019-01-30 9:57 ` Paolo Bonzini
2019-01-30 10:02 ` Thomas Huth
2019-01-30 10:15 ` Paolo Bonzini
2019-01-30 11:00 ` Cédric Le Goater
2019-01-30 11:04 ` Thomas Huth
2019-01-30 11:12 ` Cédric Le Goater
2019-01-30 9:43 ` [Qemu-devel] [RFC PATCH 2/5] ppc: Express dependencies of the 'prep' and '40p' " Thomas Huth
2019-01-30 10:17 ` Paolo Bonzini
2019-01-30 10:25 ` Thomas Huth [this message]
2019-01-30 11:02 ` Thomas Huth
2019-01-30 11:10 ` Paolo Bonzini
2019-01-30 11:09 ` Paolo Bonzini
2019-01-30 9:43 ` [Qemu-devel] [RFC PATCH 3/5] ppc: Express dependencies of the Mac " Thomas Huth
2019-01-30 10:18 ` Paolo Bonzini
2019-01-30 17:13 ` Mark Cave-Ayland
2019-01-30 17:21 ` Paolo Bonzini
2019-01-31 5:23 ` Thomas Huth
2019-01-30 9:43 ` [Qemu-devel] [RFC PATCH 4/5] ppc: Express dependencies of the Sam460EX " Thomas Huth
2019-01-30 10:18 ` Paolo Bonzini
2019-01-30 11:29 ` BALATON Zoltan
2019-01-30 12:03 ` Thomas Huth
2019-01-30 9:43 ` [Qemu-devel] [RFC PATCH 5/5] ppc: Express dependencies of the embedded " Thomas Huth
2019-01-30 10:18 ` Paolo Bonzini
2019-01-30 10:59 ` [Qemu-devel] [RFC PATCH 0/5] Kconfig dependencies for ppc machines Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c26ebf71-70e5-4162-6039-4d13654c780c@redhat.com \
--to=thuth@redhat.com \
--cc=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).