From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C881BD10BFC for ; Sat, 26 Oct 2024 15:32:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4imV-0007m6-5O; Sat, 26 Oct 2024 11:32:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4imS-0007kz-33; Sat, 26 Oct 2024 11:32:44 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t4imQ-0002zH-3e; Sat, 26 Oct 2024 11:32:43 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-20cceb8d8b4so16549995ad.1; Sat, 26 Oct 2024 08:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729956759; x=1730561559; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=/E+P9XDtTfhdme2tZGAF7PlqHwrHS7iT886fnkgkgcI=; b=G9KPA5riHazgfXKqjwJegXGnNRDXQnxXLNiXC0BZcrQNs6x/Yinzw94vkiGnuzrXK6 EjRbuzpIJ3kYjUcSsEF78JU2UxY5Ssb4bu5HKUxrXyWE2S7laTtX8zfTsH7rUz8yOJ1H FkqTxzyn3zi/BHQUQ1dHeyuadtklCBpGlXA8YRNLjZ7dQhmjW+MOGLyDCWQsEk2kMID2 Ml1QqnnNZz0lCyQWT3/hXZHNHiDPNk9/w7xRpOpcWd442Sq9HTQSv+++j06AFJ9ZKElh tqZjPbXy9ym2YArHmDny2FUUtH0Bt9PbLiIkPsXJAgzECppArSE8RdlO2hKiUEN6K99+ dFDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729956759; x=1730561559; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/E+P9XDtTfhdme2tZGAF7PlqHwrHS7iT886fnkgkgcI=; b=YGj4IprsGWLcPmUfiW1u6SEBUgCvrRK/NS2rtHfzyXxtmi0e6N+BZBOXmDAPURXsjU tW4MI+ot6UFfs8oUxeaweDpEhIEMQpZL3RTTD/GA2wHzTcJ1ctGXYIUOOJK4i2GirvNG F1Di1NgsTBVEOPUVtiW7inAuA9uU4iPByagy98IIoEe1H4m+i71ILv2FI8LD6zwao4UQ A3WmX85IaqdTh+lGS/RcfiWccqdsot+xWd+90Hrxi88YETnJgOLZEQB7iGGq1YYe4OAC tmUgZ2Lzm5evPUkGhsqcoHAg4uLhdi+07r3qZxBQqm32Uu/NBZMObcbGXPD+L9cfqz8g xehw== X-Forwarded-Encrypted: i=1; AJvYcCUk+EfBeBvv8BrVw6WwlxrrtD3Y4KIJ1kcuqVyDIuwtsAFv+doQBwvG+Pr1FN/GzHaFJAZCTb5g+5xk@nongnu.org, AJvYcCXAkslEv1uuXsnfVnPEeqlAxdnyriyM31X/NLGCfEQe7Zm5OQYyoDBkI7P/QD5NjI89dX0UghdtxYbeXQ==@nongnu.org X-Gm-Message-State: AOJu0YxG2wUt+bJDEjNnFYq5R//DF3WOhkhQ5zqibbJbJZEaKVK1zp3l h7K3A0ulJNM/nCra7RacDSGND3LBwSVVMXcUbup/6u5tX4FnhYi/ X-Google-Smtp-Source: AGHT+IHJFsko9Gt5kqf7/+xj5dbORSdSlwRqQWN/6nz+Qb5ZLldxm0cI1HOyFRJm4Esv58tn7+lp8Q== X-Received: by 2002:a17:902:e88e:b0:205:8b84:d5e8 with SMTP id d9443c01a7336-210c59e2580mr45231885ad.18.1729956759422; Sat, 26 Oct 2024 08:32:39 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc02f6f1sm25370515ad.226.2024.10.26.08.32.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Oct 2024 08:32:38 -0700 (PDT) Message-ID: Date: Sat, 26 Oct 2024 08:32:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] arm: Add collie and sx functional tests To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , =?UTF-8?Q?Jan_L=C3=BCbbe?= Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Thomas Huth , Peter Maydell , Joel Stanley , qemu-block References: <20241017163247.711244-1-peter.maydell@linaro.org> <5262a33d-d0c5-452b-9869-f8f482b1c857@linaro.org> <07664ec3-6b46-4b27-9d8c-9e2ff34c9dbe@kaod.org> <600baa43c3dd3547338934717cfb57c5e12b0d23.camel@pengutronix.de> <84c32f2d-7d9a-4e5a-8b67-1f954dd493f6@roeck-us.net> <53cbb597-e7f2-4742-bf85-928c704ddbcf@linaro.org> <443f1b0c-8184-4bf4-9f68-c23d7de3bc36@roeck-us.net> <1bce4c22-9281-44c5-8acb-860881dc271c@kaod.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <1bce4c22-9281-44c5-8acb-860881dc271c@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=groeck7@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.171, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/26/24 03:02, Cédric Le Goater wrote: [ ... ] >> I don't mind a single file. What bothers me is that the partitioning is made >> mandatory for ast2600 even if not used. > > Our only use case, in 2019, was to boot QEMU ast2600 machines from an > eMMC device using an OpenBMC FW image like the ones we find on IBM > Power10 Rainier systems. I agree we only focused on this scenario. > Most of the support should be there for other use cases, and it's now > a question of finding the right tunables for the user. > > I did a quick experiment using 2 patches, > > one on hw/sd/sd.c to fix c8cb19876d3e ("hw/sd/sdcard: Support boot > area in emmc image") > >     @@ -826,7 +826,9 @@ static void sd_reset(DeviceState *dev) >              sect = 0; >          } >          size = sect << HWBLOCK_SHIFT; >     -    size -= sd_bootpart_offset(sd); >     +    if (sd_is_emmc(sd)) { >     +        size -= sd->boot_part_size * 2; >     +    } >          sect = sd_addr_to_wpnum(size) + 1; > > and another on hw/arm/aspeed.c to remove the setting of the eMMC > device properties when it is not bootable : >     @@ -338,7 +338,7 @@ static void sdhci_attach_drive(SDHCIStat >                  return; >              } >              card = qdev_new(emmc ? TYPE_EMMC : TYPE_SD_CARD); >     -        if (emmc) { >     +        if (emmc && boot_emmc) { >                  qdev_prop_set_uint64(card, "boot-partition-size", 1 * MiB); >                  qdev_prop_set_uint8(card, "boot-config", >                                      boot_emmc ? 0x1 << 3 : 0x0); > (I am not saying this is correct) > Works for me, though, and it is much better than mandating the existence of boot partitions. If you end up submitting those patches, please feel free to add Tested-by: Guenter Roeck Thanks, Guenter