From: Thomas Huth <thuth@redhat.com>
To: quintela@redhat.com, Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P.Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 1/9] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable
Date: Wed, 11 Oct 2023 16:30:29 +0200 [thread overview]
Message-ID: <c28f82cf-6b97-47aa-872a-c2ca0599ff51@redhat.com> (raw)
In-Reply-To: <87a5sp9rbj.fsf@secure.mitica>
On 11/10/2023 16.17, Juan Quintela wrote:
> Fabiano Rosas <farosas@suse.de> wrote:
>> We're adding support for testing migration using two different QEMU
>> binaries. We'll provide the second binary in a new environment
>> variable.
>>
>> Allow qtest_qemu_binary() to receive the name of the new variable. If
>> the new environment variable is not set, that's not an error, we use
>> QTEST_QEMU_BINARY as a fallback.
>>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> Thomas, do you want me to get this through the migration tree?
I'm fine either way, but please give me one or two more days for review first.
Thomas
next prev parent reply other threads:[~2023-10-11 14:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:39 [PATCH v2 0/9] tests/migration-test: Allow testing older machine types Fabiano Rosas
2023-10-06 12:39 ` [PATCH v2 1/9] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable Fabiano Rosas
2023-10-11 14:17 ` Juan Quintela
2023-10-11 14:30 ` Thomas Huth [this message]
2023-10-11 14:32 ` Juan Quintela
2023-10-11 14:55 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 2/9] tests/qtest: Introduce qtest_init_with_env Fabiano Rosas
2023-10-11 14:20 ` Juan Quintela
2023-10-11 14:56 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 3/9] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary Fabiano Rosas
2023-10-11 14:22 ` Juan Quintela
2023-10-11 15:05 ` Thomas Huth
2023-10-12 7:49 ` Thomas Huth
2023-10-12 14:53 ` Fabiano Rosas
2023-10-16 16:00 ` Fabiano Rosas
2023-10-06 12:39 ` [PATCH v2 4/9] tests/qtest: Introduce qtest_has_machine_with_env Fabiano Rosas
2023-10-11 14:22 ` Juan Quintela
2023-10-11 15:06 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 5/9] tests/qtest: Introduce qtest_resolve_machine_alias Fabiano Rosas
2023-10-11 14:23 ` Juan Quintela
2023-10-11 15:25 ` Thomas Huth
2023-10-11 15:47 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 6/9] tests/qtest/migration: Introduce find_common_machine_version Fabiano Rosas
2023-10-11 14:25 ` Juan Quintela
2023-10-11 15:50 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 7/9] tests/qtest/migration: Define a machine for all architectures Fabiano Rosas
2023-10-11 14:28 ` Juan Quintela
2023-10-11 14:40 ` Fabiano Rosas
2023-10-11 14:48 ` Daniel P. Berrangé
2023-10-11 14:59 ` Fabiano Rosas
2023-10-17 12:53 ` Fabiano Rosas
2023-10-11 15:55 ` Thomas Huth
2023-10-06 12:39 ` [PATCH v2 8/9] tests/qtest/migration: Support more than one QEMU binary Fabiano Rosas
2023-10-11 14:31 ` Juan Quintela
2023-10-06 12:39 ` [PATCH v2 9/9] tests/qtest: Don't print messages from query instances Fabiano Rosas
2023-10-11 14:31 ` Juan Quintela
2023-10-11 15:59 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28f82cf-6b97-47aa-872a-c2ca0599ff51@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).