From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:57667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giL63-0008Mq-TY for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:21:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giKxY-0008OF-Il for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:12:30 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:34766) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giKxV-0008MK-02 for qemu-devel@nongnu.org; Sat, 12 Jan 2019 10:12:26 -0500 Received: by mail-wr1-x443.google.com with SMTP id j2so18315325wrw.1 for ; Sat, 12 Jan 2019 07:12:23 -0800 (PST) References: <20190109201956.3982-1-yuval.shaia@oracle.com> From: Marcel Apfelbaum Message-ID: Date: Sat, 12 Jan 2019 17:12:33 +0200 MIME-Version: 1.0 In-Reply-To: <20190109201956.3982-1-yuval.shaia@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH] hw/rdma: Delete unused struct member List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuval Shaia , qemu-devel@nongnu.org On 1/9/19 10:19 PM, Yuval Shaia wrote: > This member is used only in init_device_caps function, make it local. > > Signed-off-by: Yuval Shaia > --- > hw/rdma/rdma_backend.c | 26 ++++++++++++++------------ > hw/rdma/rdma_backend_defs.h | 1 - > 2 files changed, 14 insertions(+), 13 deletions(-) > > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c > index 16dca69ee9..b49edaacaf 100644 > --- a/hw/rdma/rdma_backend.c > +++ b/hw/rdma/rdma_backend.c > @@ -917,23 +917,25 @@ void rdma_backend_destroy_qp(RdmaBackendQP *qp) > static int init_device_caps(RdmaBackendDev *backend_dev, > struct ibv_device_attr *dev_attr) > { > - if (ibv_query_device(backend_dev->context, &backend_dev->dev_attr)) { > + struct ibv_device_attr bk_dev_attr; > + > + if (ibv_query_device(backend_dev->context, &bk_dev_attr)) { > return -EIO; > } > > dev_attr->max_sge = MAX_SGE; > > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_mr_size, "%" PRId64); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_qp, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_sge, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_qp_wr, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_cq, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_cqe, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_mr, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_pd, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_qp_rd_atom, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_qp_init_rd_atom, "%d"); > - CHK_ATTR(dev_attr, backend_dev->dev_attr, max_ah, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_mr_size, "%" PRId64); > + CHK_ATTR(dev_attr, bk_dev_attr, max_qp, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_sge, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_qp_wr, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_cq, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_cqe, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_mr, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_pd, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_qp_rd_atom, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_qp_init_rd_atom, "%d"); > + CHK_ATTR(dev_attr, bk_dev_attr, max_ah, "%d"); > > return 0; > } > diff --git a/hw/rdma/rdma_backend_defs.h b/hw/rdma/rdma_backend_defs.h > index 1e5c3dd3bf..15ae8b970e 100644 > --- a/hw/rdma/rdma_backend_defs.h > +++ b/hw/rdma/rdma_backend_defs.h > @@ -41,7 +41,6 @@ typedef struct RdmaCmMux { > } RdmaCmMux; > > typedef struct RdmaBackendDev { > - struct ibv_device_attr dev_attr; > RdmaBackendThread comp_thread; > PCIDevice *dev; > RdmaDeviceResources *rdma_dev_res; Reviewed-by: Marcel Apfelbaum Thanks, Marcel