From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E11F8C3DA78 for ; Tue, 17 Jan 2023 13:54:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHmQ7-0004lL-BB; Tue, 17 Jan 2023 08:54:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHmQ5-0004ks-Qz for qemu-devel@nongnu.org; Tue, 17 Jan 2023 08:54:33 -0500 Received: from imap4.hz.codethink.co.uk ([188.40.203.114]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHmQ3-0006Br-VQ for qemu-devel@nongnu.org; Tue, 17 Jan 2023 08:54:33 -0500 Received: from cpc152649-stkp13-2-0-cust121.10-2.cable.virginm.net ([86.15.83.122] helo=[192.168.0.16]) by imap4.hz.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1pHm4j-006WN6-8u; Tue, 17 Jan 2023 13:32:30 +0000 Message-ID: Date: Tue, 17 Jan 2023 13:32:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] hw/net/can: Add mcp25625 model Content-Language: en-GB To: Ben Dooks , jasowang@redhat.com, pisa@cmp.felk.cvut.cz, fnu.vikram@xilinx.com, qemu-devel@nongnu.org Cc: Nazar Kazakov , Lawrence Hunter , Frank Chang References: <20230104122220.110412-1-ben.dooks@codethink.co.uk> From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <20230104122220.110412-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=188.40.203.114; envelope-from=ben.dooks@codethink.co.uk; helo=imap4.hz.codethink.co.uk X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.097, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 04/01/2023 12:22, Ben Dooks wrote: > From: Ben Dooks > > Add support for Microchip MCP25625 SPI based CAN controller which is > very similar to the MCP2515 (and covered by the same Linux driver). > > This can be added to any machine with SPI support in the machine > model file. > > Example for using this when configured into a machine: > > -object can-bus,id=canbus0 \ > -object can-host-socketcan,id=canhost0,if=vcan0,canbus=canbus0 \ > -global driver=mcp25625,property=canbus,value=canbus0 > > There is tracing support with --trace "*mcp25*" > > Signed-off-by: Ben Dooks > Co-developed-by: Nazar Kazakov > Signed-off-by: Nazar Kazakov > Co-developed-by: Lawrence Hunter > Signed-off-by: Lawrence Hunter > Reviewed-by: Frank Chang Has anyone had chance to review this, it would be great to get this moving along. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html