From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXFyx-0002mb-7k for qemu-devel@nongnu.org; Mon, 17 Jul 2017 20:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXFys-0002Zd-Jy for qemu-devel@nongnu.org; Mon, 17 Jul 2017 20:03:19 -0400 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:36859) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXFys-0002ZF-Fj for qemu-devel@nongnu.org; Mon, 17 Jul 2017 20:03:14 -0400 Received: by mail-qk0-x242.google.com with SMTP id d136so626575qkg.3 for ; Mon, 17 Jul 2017 17:03:14 -0700 (PDT) Sender: Richard Henderson References: <1500235468-15341-1-git-send-email-cota@braap.org> <1500235468-15341-27-git-send-email-cota@braap.org> From: Richard Henderson Message-ID: Date: Mon, 17 Jul 2017 14:03:09 -1000 MIME-Version: 1.0 In-Reply-To: <1500235468-15341-27-git-send-email-cota@braap.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 26/45] translate-all: define and use DEBUG_TB_CHECK_GATE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org On 07/16/2017 10:04 AM, Emilio G. Cota wrote: > This prevents bit rot by ensuring the debug code is compiled when > building a user-mode target. > > Unfortunately the helpers are user-mode-only so we cannot fully > get rid of the ifdef checks. Add a comment to explain this. > > Suggested-by: Alex Bennée > Signed-off-by: Emilio G. Cota > --- > accel/tcg/translate-all.c | 28 ++++++++++++++++++++++------ > 1 file changed, 22 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~