From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A981C4167B for ; Thu, 30 Nov 2023 07:39:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8bdP-0006Xf-F3; Thu, 30 Nov 2023 02:38:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8bdL-0006Ss-3p for qemu-devel@nongnu.org; Thu, 30 Nov 2023 02:38:52 -0500 Received: from mgamail.intel.com ([192.55.52.88]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8bdJ-0005sn-09 for qemu-devel@nongnu.org; Thu, 30 Nov 2023 02:38:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701329929; x=1732865929; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=30O8Y+FFJR4EB1sJ9gV1RfLIWaUgdgccOeSvL7lYnNI=; b=cMS063ebjpq5yqNTrJQEYCzZZ9LNCan7Y7qHOuwXaaHr2ugZl2rMmPw6 A+PDnNdcP8zUINFm++8AU5LcRhPPf5BJyHCREnhlPVqDjYx2Al+Li/JUP 2MvhQGIAZJuJEKWOgri8WCqzeMOLxBFwuwLW8KV6sFlogc+fhOaZ61B8p 5O9+pd1oCE3UJ+p31ksFQ6JOfM9jSstSv8GeWwcvjUGOFr3itQrczxWvv EkrXnXUl+G7z1P84FJj/1tK36xeVj31zEIIdMCdb+zgQlyO3UicMOtZVv GgOZR2wqD7grKLRk7WzOCeM/NWTGHOdE+Izi/D464QVY8rhuBFEhmQDqb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="424432651" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="424432651" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 23:38:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="798195968" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="798195968" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.29.154]) ([10.93.29.154]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 23:38:38 -0800 Message-ID: Date: Thu, 30 Nov 2023 15:38:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/70] HostMem: Add mechanism to opt in kvm guest memfd via MachineState Content-Language: en-US To: David Hildenbrand , Paolo Bonzini , Igor Mammedov , "Michael S . Tsirkin" , Marcel Apfelbaum , Richard Henderson , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Cornelia Huck , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Eric Blake , Markus Armbruster , Marcelo Tosatti Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Michael Roth , Sean Christopherson , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang References: <20231115071519.2864957-1-xiaoyao.li@intel.com> <20231115071519.2864957-5-xiaoyao.li@intel.com> <6674dc2c-f1ed-496e-bc17-256869bdeae9@intel.com> <0ca6a665-ce88-4c81-927d-6e94a249949d@redhat.com> From: Xiaoyao Li In-Reply-To: <0ca6a665-ce88-4c81-927d-6e94a249949d@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=192.55.52.88; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.999, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/20/2023 5:30 PM, David Hildenbrand wrote: > On 16.11.23 03:53, Xiaoyao Li wrote: >> On 11/16/2023 2:14 AM, David Hildenbrand wrote: >>> On 15.11.23 08:14, Xiaoyao Li wrote: >>>> Add a new member "require_guest_memfd" to memory backends. When it's >>>> set >>>> to true, it enables RAM_GUEST_MEMFD in ram_flags, thus private kvm >>>> guest_memfd will be allocated during RAMBlock allocation. >>>> >>>> Memory backend's @require_guest_memfd is wired with >>>> @require_guest_memfd >>>> field of MachineState. MachineState::require_guest_memfd is supposed to >>>> be set by any VMs that requires KVM guest memfd as private memory, >>>> e.g., >>>> TDX VM. >>>> >>>> Signed-off-by: Xiaoyao Li >>> >>> I'm confused, why do we need this if it's going to be the same for all >>> memory backends right now? >>> >> >> I want to provide a elegant (in my sense) way to configure "the need of >> guest memfd" instead of checking x86machinestate->vm_type in physmem.c >> > > It's suboptimal right now, but I guess you want to avoid looking up the > machine e.g., in ram_backend_memory_alloc(). > > I'd suggest s/require_guest_memfd/guest_memfd/gc in "struct > HostMemoryBackend". sure! > Apart from that LGTM. >