From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D91C2D0A3 for ; Thu, 12 Nov 2020 08:13:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C541020709 for ; Thu, 12 Nov 2020 08:13:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EY85NdfE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C541020709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd7j1-0000CZ-KN for qemu-devel@archiver.kernel.org; Thu, 12 Nov 2020 03:12:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kd7i3-0007j9-Gv for qemu-devel@nongnu.org; Thu, 12 Nov 2020 03:11:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kd7i0-0007WH-6h for qemu-devel@nongnu.org; Thu, 12 Nov 2020 03:11:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605168714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W2Mc75XsBbGazZvneISgPY/O83VGxFTjRFw2SLDJeCE=; b=EY85NdfEhzixoz1bHkGdDG+6LS8pvId9p5bptgx0BrpHJ6dUeE1pm7ENSC5G+xYu6OQ8bk dtMjvOz1oNmfI7cEydPB13I6Z8P+qcpokOswzbOLRV8DGHD11+j48wf0aDnf6DXtyB+OE2 4HIvQZSRvsT2GTtimprq4o8nLWDWC8M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-c54QcdByPN6maXOTFJCuSw-1; Thu, 12 Nov 2020 03:11:53 -0500 X-MC-Unique: c54QcdByPN6maXOTFJCuSw-1 Received: by mail-wm1-f71.google.com with SMTP id 14so1840437wmg.1 for ; Thu, 12 Nov 2020 00:11:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W2Mc75XsBbGazZvneISgPY/O83VGxFTjRFw2SLDJeCE=; b=CaE5WQBxkw9IG8+5KMUkbgRiPyKtdzRuVHDd13vbDEXn6dYkoRlkLC+nQWJaEW5DP7 bRmEKAMLVcRohe4jmmxapkU0OHQKnOxcdZIRmOY7IRHrOL8aFDdLbuljETVWK85jAcuX CAUTcCtK/+i845/8gLbhBANVbymKoN6VZm7kan+KWuicptki546scMaOvcnpW6YPvop1 LpAgvtdHmUOd7RAwmZIOQ/XJffEt38Qs3DpIauF/6hqagzGFgr8cK11t86qXr6CiamF6 EfVv/kMAVPIBYy9INTv2JEf7VrmcpsTMFFdLTjoURt7tx/ah1lcCTTqOwoP6fL+ynvZH EmVw== X-Gm-Message-State: AOAM531vds2spLV58fDfDj0tmMnl7xIt0MhakvPG8lmaFaUDBmTlsdmg r3l1Lbltvs5I8yFTYPHi2h4OhHZWI6X/QZVKcI4TP0vWbWFgv4WXTmcprLiwwA+wDzfmBuEQ5Iu sou+RKRQYeWBCqaM= X-Received: by 2002:adf:8521:: with SMTP id 30mr13437372wrh.265.1605168711711; Thu, 12 Nov 2020 00:11:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0q5AwtaFFfg3/+gJaGxQjR5Phrom9qYu6ScwyEasP6VqHs8RyB79A4vXt40n8cmi8i7nVVg== X-Received: by 2002:adf:8521:: with SMTP id 30mr13437345wrh.265.1605168711464; Thu, 12 Nov 2020 00:11:51 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id b63sm5957669wme.9.2020.11.12.00.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 00:11:50 -0800 (PST) Subject: Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type To: Eduardo Habkost , Kevin Wolf References: <20201109113404.GA24970@merkur.fritz.box> <3b711053-e67a-86fb-59e7-c06948dd8928@redhat.com> <20201109152125.GZ5733@habkost.net> <2300fd53-afa1-b957-b33b-cff2986fcb93@redhat.com> <20201109171618.GA5733@habkost.net> <098ca211-3ad5-b194-e9f5-678291fe641e@redhat.com> <20201109185558.GB5733@habkost.net> <9659e726-7948-4e02-f303-abcbe4c96148@redhat.com> <20201109202855.GD5733@habkost.net> <20201110103804.GA6362@merkur.fritz.box> <20201111183905.GO5733@habkost.net> From: Paolo Bonzini Message-ID: Date: Thu, 12 Nov 2020 09:11:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201111183905.GO5733@habkost.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/12 00:52:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Markus Armbruster , Igor Mammedov , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , John Snow , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/11/20 19:39, Eduardo Habkost wrote: > I will submit v3 of this series with both > object_class_property_add_field() and > object_class_add_field_properties() as internal QOM APIs. > object_class_add_field_properties() will be used to implement > device_class_set_props(). I have no problem making both of them public APIs. If an object can use only a single array of static^Wfield properties that's totally fine; I'm just not sure about splitting properties between class_init and static arrays, which is the less consistent case. Paolo