From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH 0/3] Reorg ppc64 pmu insn counting
Date: Thu, 30 Dec 2021 19:12:26 -0300 [thread overview]
Message-ID: <c2d241d4-d466-c599-e00e-3fdb62722bbb@gmail.com> (raw)
In-Reply-To: <1928bc96-ace5-3e5b-2da2-723ef3071173@linaro.org>
On 12/23/21 18:19, Richard Henderson wrote:
> On 12/23/21 12:36 PM, Daniel Henrique Barboza wrote:
>> This reorg is breaking PMU-EBB tests, unfortunately. These tests are run from the kernel
>> tree [1] and I test them inside a pSeries TCG guest. You'll need to apply patches 9 and
>> 10 of [2] beforehand (they apply cleanly in current master) because they aren't upstream
>> yet and EBB needs it.
>>
>> The tests that are breaking consistently with this reorg are:
>>
>> back_to_back_ebbs_test.c
>> cpu_event_pinned_vs_ebb_test.c
>> cycles_test.c
>> task_event_pinned_vs_ebb_test.c
>
> In which case perhaps drop my first patch for now, and instead simply replicate your tcg algorithm in c exactly -- using none of the helpers that currently exist.
>
> We can improve the code, and the use of pmc_get_event from hreg_compute_hregs_value second.
While attempting to do that I figured what was off with this series and ended up
fixing it.
It's now working with the event-based branch interrupt tests and Avocado seems happy
as well. It took some small adjustments/fixes in patches 1/2 and an extra patch of mine
tuning the existing logic after the reorg.
I'll clean it up and re-send it next week/year.
Thanks
Daniel
>
>
> r~
next prev parent reply other threads:[~2021-12-30 22:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 3:01 [PATCH 0/3] Reorg ppc64 pmu insn counting Richard Henderson
2021-12-23 3:01 ` [PATCH 1/3] target/ppc: Cache per-pmc insn and cycle count settings Richard Henderson
2021-12-23 3:01 ` [PATCH 2/3] target/ppc: Rewrite pmu_increment_insns Richard Henderson
2021-12-23 3:01 ` [PATCH 3/3] target/ppc: Use env->pnc_cyc_cnt Richard Henderson
2021-12-23 20:36 ` [PATCH 0/3] Reorg ppc64 pmu insn counting Daniel Henrique Barboza
2021-12-23 21:19 ` Richard Henderson
2021-12-23 22:47 ` Daniel Henrique Barboza
2021-12-30 22:12 ` Daniel Henrique Barboza [this message]
2022-01-03 6:48 ` Cédric Le Goater
2022-01-03 11:10 ` Daniel Henrique Barboza
2022-01-03 15:07 ` Alex Bennée
2022-01-03 18:06 ` Daniel Henrique Barboza
2022-01-04 10:32 ` Alex Bennée
2022-01-04 19:56 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2d241d4-d466-c599-e00e-3fdb62722bbb@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).