From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACC84EB64D9 for ; Fri, 7 Jul 2023 11:07:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHjJF-0003AH-CY; Fri, 07 Jul 2023 07:07:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHjJ7-000380-7u for qemu-devel@nongnu.org; Fri, 07 Jul 2023 07:07:26 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHjIw-0000dz-4J for qemu-devel@nongnu.org; Fri, 07 Jul 2023 07:07:19 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so2762055e87.2 for ; Fri, 07 Jul 2023 04:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688728031; x=1691320031; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F0xN/Il7udj313sbDORLEDrsP7aZXskElEkNrr+slBU=; b=gAMWkPw2zztYgeGKs2zk9VBFWXOEntVYCCAeVSxx1WLdd6ZtpaLLCGJFjufTLhDu1H 8wvWW+ruDdrsqZAjrwoVbAKWWVPoUDBWN1FdZzPYnH63wLnlyLgbECUci8m4g4HTRu1D t6IjBc6/NCYAx9XXJjIjHvp8nTLT3ZBDBCGYJ4prYaz2QrFVxS0kAaldDRmGBoSsmtjX l3hOBhaN20LRF18vCT6qyXye80w8rw3memlk71LaUduyxl3PiAJVP3QaVg0uo3SAwgfV 4Yf0jsT1eFR0ieZUCg6ed8Mmu90mk177T1X5oKcqc7TsG92NwqSJ0Sej3Jrn126GUYHg IaSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688728031; x=1691320031; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F0xN/Il7udj313sbDORLEDrsP7aZXskElEkNrr+slBU=; b=a1xKUGDT+pQ8J/fvfBMdWx+aEdC3VPXzPtX0cYzNPu7M2ecBUv1qy43SO+rsuqQdtJ Iy1SsIpRO75f9e7gKekhVtuTm9S7+Eiy9iRGnXNVDULR4Hdksq0XVwwwF2hINsSZM0nT DOZJyNbTxCFdb+g6X/2zuVGCb2E/gJDSk7AxsVpjuRnIPaeJHQxn4WhRcuP2EJ3uOn/M f+6Rw62BQKn67J5Tg4wpGxwWL8LVvriNLQ+v8PrGJVjXyB+Fed91Z3BpJnwdOy0ZMaoK m5JzE0iMNoHhwcp1wgcXaI+L1FXvAUPmhriYl4HSrXkKI5Hcl/uScbUtcOuT0A7Jg0Cw vYSQ== X-Gm-Message-State: ABy/qLZDIitRExwWim57z+sHTEBNReOcS1shLNoI/HP0g/k61Gaj9oly Oeyoh+PUWMrL7WB8cqFsavrUAZUFW2ko/sBDfr8= X-Google-Smtp-Source: APBJJlG26B4tRlOBpx2YT33r9MflYhjzb7LDlbUE3PCvExlwh3716Bj+hWOO27R3yZjca/2czALQ6Q== X-Received: by 2002:a05:6512:3da8:b0:4fb:8b2a:a4af with SMTP id k40-20020a0565123da800b004fb8b2aa4afmr4893812lfv.2.1688728030921; Fri, 07 Jul 2023 04:07:10 -0700 (PDT) Received: from [192.168.82.227] ([91.223.100.9]) by smtp.gmail.com with ESMTPSA id l14-20020ac24a8e000000b004fb9536bc99sm639399lfp.169.2023.07.07.04.07.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 04:07:10 -0700 (PDT) Message-ID: Date: Fri, 7 Jul 2023 12:07:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 16/46] target/loongarch: Implement xvmadd/xvmsub/xvmaddw{ev/od} Content-Language: en-US To: Song Gao , qemu-devel@nongnu.org References: <20230630075904.45940-1-gaosong@loongson.cn> <20230630075904.45940-17-gaosong@loongson.cn> From: Richard Henderson In-Reply-To: <20230630075904.45940-17-gaosong@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=richard.henderson@linaro.org; helo=mail-lf1-x136.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.091, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/30/23 08:58, Song Gao wrote: > +#define XVMADD_Q(NAME, FN, idx1, idx2) \ > +static bool trans_## NAME(DisasContext *ctx, arg_vvv * a) \ > +{ \ > + TCGv_i64 rh, rl, arg1, arg2, th, tl; \ > + int i; \ > + \ > + CHECK_VEC; \ > + \ > + rh = tcg_temp_new_i64(); \ > + rl = tcg_temp_new_i64(); \ > + arg1 = tcg_temp_new_i64(); \ > + arg2 = tcg_temp_new_i64(); \ > + th = tcg_temp_new_i64(); \ > + tl = tcg_temp_new_i64(); \ > + \ > + for (i = 0; i < 2; i++) { \ > + get_vreg64(arg1, a->vj, idx1 + i * 2); \ > + get_vreg64(arg2, a->vk, idx2 + i * 2); \ > + get_vreg64(rh, a->vd, 1 + i * 2); \ > + get_vreg64(rl, a->vd, 0 + i * 2); \ > + \ > + tcg_gen_## FN ##_i64(tl, th, arg1, arg2); \ > + tcg_gen_add2_i64(rl, rh, rl, rh, tl, th); \ > + \ > + set_vreg64(rh, a->vd, 1 + i * 2); \ > + set_vreg64(rl, a->vd, 0 + i * 2); \ > + } \ > + \ > + return true; \ > +} It's easier to debug if you make this a function, into which you pass parameters, like tcg_gen_muls2_i64. > + len = (simd_oprsz(v) == 16) ? LSX_LEN : LASX_LEN; \ > + for (i = 0; i < len / BIT; i++) { \ More of this. r~