qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Erokhin <language.lawyer@gmail.com>
To: qemu-devel@nongnu.org
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>
Subject: Re: [RFC PATCH] virtfs: 9p: local: add default uid and gid options
Date: Sat, 6 Dec 2025 22:10:58 +0500	[thread overview]
Message-ID: <c2d79567-6b6c-4222-b1df-550db57ad626@gmail.com> (raw)
In-Reply-To: <5030911.GXAFRqVoOG@weasel>

On 03/12/2025 15:33, Christian Schoenebeck wrote:
> On Monday, 1 December 2025 19:00:53 CET Andrey Erokhin wrote:
>> I was trying to boot from a directory tree owned by an ordinary user,
>> and some daemons weren't happy about non-root ownership of some files
>>
>> Example use:
>> -virtfs local,path=rootfs,mount_tag=root,security_model=mapped,uid=0,gid=0
>>
>> Works with any security_model
> 
> First I thought do we really want to open that rabbit hole and add permission management to the CLI options? However I get why this might be useful for  mapped[-*] security models.
> But for passthrough it is not of any use, is it?

Prolly none, just a side effect of how it's implemented.
Can either make it an error when used with passthrough, or ignore them (use default -1 value) when copying options to 9p fs context (with or without a warning)
 
> Also while it is very handy to have a short option name like "uid" and "gid", for the sake of long term progression and clarity an option name like "default-uid" would be more appropriate.

Or rather default_uid, to match other options style? But uid/gid also kinda match fmode/dmode :\

> The patch is also missing the required documentation changes for these new options BTW.

Haven’t added them yet, wasn’t sure there would be interest in this feature


  reply	other threads:[~2025-12-06 17:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01 18:00 [RFC PATCH] virtfs: 9p: local: add default uid and gid options Andrey Erokhin
2025-12-03 10:33 ` Christian Schoenebeck
2025-12-06 17:10   ` Andrey Erokhin [this message]
2025-12-07 11:34     ` Warner Losh
2025-12-09 10:21       ` Christian Schoenebeck
2025-12-09 10:38         ` Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2d79567-6b6c-4222-b1df-550db57ad626@gmail.com \
    --to=language.lawyer@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).