Re: [PATCH] contrib: add stub bridge.conf for qemu-bridge-helper

[Cole Robinson <crobinso@redhat.com>]

On 7/8/21 2:42 PM, Cole Robinson wrote:
> The comment comes from OpenSUSE's bridge.conf, with some minor tweaks
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> Or should this be installed? If so where in git should it live?
> 
>  contrib/bridge.conf | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 contrib/bridge.conf
> 
> diff --git a/contrib/bridge.conf b/contrib/bridge.conf
> new file mode 100644
> index 0000000000..b83e46c34f
> --- /dev/null
> +++ b/contrib/bridge.conf
> @@ -0,0 +1,14 @@
> +# Access control file for qemu-bridge-helper
> +# https://wiki.qemu.org/Features/HelperNetworking
> +#
> +# Syntax consists of:
> +#   # comment (ignored)
> +#   allow all
> +#   allow <bridge_name>
> +#   deny all
> +#   deny <bridge_name>
> +#   include /path/to/additional/ACL/file
> +#
> +# Users are blacklisted by default and 'deny' takes precedence over 'allow'.
> +# Including additional ACL files allows file access permissions to be used as
> +# a component of the policy to allow access or deny access to specific bridges.
> 

Meant to include this too:

diff --git a/MAINTAINERS b/MAINTAINERS
index 684142e12e..dbdf26ade2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2498,6 +2498,7 @@ F: include/net/
 F: qemu-bridge-helper.c
 T: git https://github.com/jasowang/qemu.git net
 F: qapi/net.json
+F: contrib/bridge.conf

 Netmap network backend
 M: Luigi Rizzo <rizzo@iet.unipi.it>

- Cole

- Cole