From: Marcel Apfelbaum <marcel@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Yuval Shaia <yuval.shaia@oracle.com>
Subject: Re: [Qemu-devel] [PATCH for-2.12] rdma: Fix 32-bit compilation
Date: Tue, 20 Mar 2018 12:36:44 +0200 [thread overview]
Message-ID: <c2da3eac-9646-fd8e-87e7-59766d1eafab@redhat.com> (raw)
In-Reply-To: <831cddaa-3803-10b1-8d6a-e878c97cca73@redhat.com>
On 20/03/2018 0:08, Eric Blake wrote:
> On 03/19/2018 04:53 PM, Eric Blake wrote:
>> Use the correct printf formats, so that a 32-bit compile doesn't
>> spit out lots of warnings about %lx being incompatible with uint64_t.
>> Broken since initial commit ef6d4ccd.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>
>> I don't know if 'make vm-build-ubuntu.i368' would catch this (it failed
>> for me for other reasons); I found it via a 32-bit rawhide VM.
>
> That fixes most of the warnings,
Thanks!
> but not:
>
> /home/dummy/qemu/hw/rdma/rdma_backend.c: In function 'rdma_backend_create_mr':
> /home/dummy/qemu/hw/rdma/rdma_backend.c:409:37: error: cast to pointer from integer of different size
> [-Werror=int-to-pointer-cast]
> m4->ibmr = ibv_reg_m4(pd->ibpd, (void *)addr, length, access);
> ^
>
So the compilation actually brakes on 32bit machines?
I'll create a VM.
Thanks,
Marcel
next prev parent reply other threads:[~2018-03-20 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 21:53 [Qemu-devel] [PATCH for-2.12] rdma: Fix 32-bit compilation Eric Blake
2018-03-19 22:08 ` Eric Blake
2018-03-20 10:36 ` Marcel Apfelbaum [this message]
2018-03-20 10:30 ` Marcel Apfelbaum
2018-03-21 1:46 ` Fam Zheng
2018-03-21 2:07 ` Fam Zheng
2018-03-21 9:20 ` Marcel Apfelbaum
2018-03-21 9:34 ` Fam Zheng
2018-03-20 10:43 ` Yuval Shaia
2018-03-21 16:52 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2da3eac-9646-fd8e-87e7-59766d1eafab@redhat.com \
--to=marcel@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).