From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8rtD-0004zd-S8 for qemu-devel@nongnu.org; Wed, 28 Sep 2011 07:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8rt2-0004Ew-FW for qemu-devel@nongnu.org; Wed, 28 Sep 2011 07:01:23 -0400 Received: from david.siemens.de ([192.35.17.14]:33123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8rt2-0004Dg-6s for qemu-devel@nongnu.org; Wed, 28 Sep 2011 07:01:12 -0400 From: Jan Kiszka Date: Wed, 28 Sep 2011 13:00:55 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 09/22] i8259: Do not update IRQ output after spurious pic_poll_read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , qemu-devel Cc: Blue Swirl If pic_poll_read finds no pending IRQ and return a spurious one instead, no PIC state is changed, thus we do not need to call pic_update_irq. Signed-off-by: Jan Kiszka --- hw/i8259.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/i8259.c b/hw/i8259.c index 65123bd..cddd3c7 100644 --- a/hw/i8259.c +++ b/hw/i8259.c @@ -393,7 +393,6 @@ static uint32_t pic_poll_read(PicState *s) pic_update_irq(s->pics_state); } else { ret = 0x07; - pic_update_irq(s->pics_state); } return ret; -- 1.7.3.4