qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org, clg@kaod.org
Cc: gkurz@kaod.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/4] xics: Eliminate unnecessary class
Date: Tue, 24 Sep 2019 11:47:51 +0200	[thread overview]
Message-ID: <c2efe040-a9f4-8d7f-f1b4-c8ef162c4560@redhat.com> (raw)
In-Reply-To: <20190924045952.11412-1-david@gibson.dropbear.id.au>

On 9/24/19 6:59 AM, David Gibson wrote:
> The XICS interrupt controller device used to have separate subtypes
> for the KVM and non-KVM variant of the device.  That was a bad idea,
> because it leaked information that should be entirely host-side
> implementation specific to the kinda-sorta guest visible QOM class
> names.
> 
> We eliminated the KVM specific class some time ago, but it's left
> behind a distinction between the TYPE_ICS_BASE abstract class and
> TYPE_ICS_SIMPLE subtype which no longer serves any purpose.
> 
> This series collapses the two types back into one.
> 
> David Gibson (4):
>   xics: Eliminate 'reject', 'resend' and 'eoi' class hooks
>   xics: Merge reset and realize hooks
>   xics: Rename misleading ics_simple_*() functions
>   xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes

Please remove the qemu_register_reset() call in hw/intc/xics.c,
then for the series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  parent reply	other threads:[~2019-09-24  9:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  4:59 [PATCH 0/4] xics: Eliminate unnecessary class David Gibson
2019-09-24  4:59 ` [PATCH 1/4] xics: Eliminate 'reject', 'resend' and 'eoi' class hooks David Gibson
2019-09-24  5:23   ` Cédric Le Goater
2019-09-24  7:28   ` Greg Kurz
2019-09-24  4:59 ` [PATCH 2/4] xics: Merge reset and realize hooks David Gibson
2019-09-24  5:26   ` Cédric Le Goater
2019-09-24  7:36   ` Greg Kurz
2019-09-24  9:44   ` Philippe Mathieu-Daudé
2019-09-24 11:40     ` David Gibson
2019-09-24  4:59 ` [PATCH 3/4] xics: Rename misleading ics_simple_*() functions David Gibson
2019-09-24  5:26   ` Cédric Le Goater
2019-09-24  7:38   ` Greg Kurz
2019-09-24  4:59 ` [PATCH 4/4] xics: Merge TYPE_ICS_BASE and TYPE_ICS_SIMPLE classes David Gibson
2019-09-24  5:31   ` Cédric Le Goater
2019-09-24 11:41     ` David Gibson
2019-09-24 14:06       ` Cédric Le Goater
2019-09-25  1:46         ` David Gibson
2019-09-25  6:04           ` Cédric Le Goater
2019-10-03 17:53             ` Cédric Le Goater
2019-09-24  7:40   ` Greg Kurz
2019-09-24  9:46   ` Philippe Mathieu-Daudé
2019-09-24  5:22 ` [PATCH 0/4] xics: Eliminate unnecessary class Cédric Le Goater
2019-09-24  7:52   ` Greg Kurz
2019-09-24  9:55     ` Cédric Le Goater
2019-09-24 10:04       ` Philippe Mathieu-Daudé
2019-09-24 11:00         ` Cédric Le Goater
2019-09-26  1:28           ` David Gibson
2019-09-24  9:47 ` Philippe Mathieu-Daudé [this message]
2019-09-24 10:06   ` Greg Kurz
2019-09-24 10:22     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2efe040-a9f4-8d7f-f1b4-c8ef162c4560@redhat.com \
    --to=philmd@redhat.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=gkurz@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).