From: Thomas Huth <thuth@redhat.com>
To: Su Hang <suhang16@mails.ucas.ac.cn>, stefanha@redhat.com
Cc: qemu-devel@nongnu.org, QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 2/3] util/uri.c: only remove `return`'s brackets
Date: Fri, 23 Feb 2018 09:47:35 +0100 [thread overview]
Message-ID: <c3078a4e-24f4-cc37-ca7f-9f40213639bb@redhat.com> (raw)
In-Reply-To: <1519372278-20644-1-git-send-email-suhang16@mails.ucas.ac.cn>
On 23.02.2018 08:51, Su Hang wrote:
> only remove brackets that wrap `return` statements' content.
>
> use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
> to remove pattern like this: "return (1);"
>
> Signed-off-by: Su Hang <suhang16@mails.ucas.ac.cn>
> ---
> util/uri.c | 160 ++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 80 insertions(+), 80 deletions(-)
Looks good to me:
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2018-02-23 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 7:51 [Qemu-devel] [PATCH v3 2/3] util/uri.c: only remove `return`'s brackets Su Hang
2018-02-23 8:47 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3078a4e-24f4-cc37-ca7f-9f40213639bb@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=suhang16@mails.ucas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).