From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7087C2D0C8 for ; Sun, 29 Dec 2019 00:05:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79A20218AC for ; Sun, 29 Dec 2019 00:05:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Pzxt4h/f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79A20218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilM4w-0008QL-Ge for qemu-devel@archiver.kernel.org; Sat, 28 Dec 2019 19:05:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53839) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilM4D-0007zJ-IX for qemu-devel@nongnu.org; Sat, 28 Dec 2019 19:04:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilM4C-0006up-FF for qemu-devel@nongnu.org; Sat, 28 Dec 2019 19:04:21 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:45381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilM4C-0006kz-4T for qemu-devel@nongnu.org; Sat, 28 Dec 2019 19:04:20 -0500 Received: by mail-pl1-x641.google.com with SMTP id b22so13226691pls.12 for ; Sat, 28 Dec 2019 16:04:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mLEr5sYBpVbmKdMkiS0l1ARDJr2IuFXAOn2DHHwAmNg=; b=Pzxt4h/fpowC/zD8syYGckIXLteumwYklcRA7XTQDi6YbKc2Bs9lKYtf0JIDpVY+fk cAdBmuu8+qzhHVw2ku0eVabcJNRtQLZ4C+942etTY3Jf9kmYuh5MDqQtvxL8nRnNFVEK nNU25L0cqtOL291gqkin2R3073HFe0150/L/vN9qFooq82wuDFidlpfMsqU2izP8STbO gwB3lgwlQqRgi9oVwgeoloZXQb+muySUg5t8Lage3Uch0MXTWe22zRL2mjydDdnZHW0n d/BEpuYam9BcW9K5neCewzfwqHK/LJD1Uwpkgq4m/BsGOE1yyKHdZ0ZcGmKUUD0LQQk0 yKeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mLEr5sYBpVbmKdMkiS0l1ARDJr2IuFXAOn2DHHwAmNg=; b=DnzB12ItAd4sRbS1mZOr9KmSn5XCqPbRJK+hhwaXwE3rKmd8d5gf0S2uON7KhdHu5c 0U1DPVs46+BI8OOHVHIC+L7H3V68J3D/8qKu7WNsut5LAdoRkVhdI2a600W06++0Z5Or UXg3vcS7D25DkZsCf9gmYKaN50M2wl9G6pk9AEh5H+7n/ASZNKswj9VNLVArGY0S4rhQ pYXaBpCRbBinGj53gKxbUDhaXQhr4h3HujGIWWIVT75Sd2l0Np1RV8ucj2tR4TnQ4T1s x+DN3pCktCUETFmYty7tVeezQbs1/z+6pCIy7258+kZlKYUWHnPJwiE36XvlzK945X9v Efyg== X-Gm-Message-State: APjAAAUYs/hMlrXtdrdSrKf6KRtFAIgdetRcJVmCBhFJN+yuhAZ6FSCT stHfcV7Qpl3zR6lEjSISfDySsA== X-Google-Smtp-Source: APXvYqxp65BT5y+lOx9FfNsoMFafl+hj+u5Z+uSA8OOJdc0QiyJBjqOqLNje1rPqmCQ5LufvQg28JA== X-Received: by 2002:a17:902:47:: with SMTP id 65mr18609013pla.130.1577577858533; Sat, 28 Dec 2019 16:04:18 -0800 (PST) Received: from [192.168.1.118] (194-223-58-9.tpgi.com.au. [194.223.58.9]) by smtp.gmail.com with ESMTPSA id z29sm44694493pge.21.2019.12.28.16.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Dec 2019 16:04:17 -0800 (PST) Subject: Re: [PATCH v6 10/11] vl: replace deprecated qbus_reset_all registration To: Damien Hedde , qemu-devel@nongnu.org References: <20191220115035.709876-1-damien.hedde@greensocs.com> <20191220115035.709876-11-damien.hedde@greensocs.com> From: Richard Henderson Message-ID: Date: Sun, 29 Dec 2019 11:04:10 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191220115035.709876-11-damien.hedde@greensocs.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, berrange@redhat.com, ehabkost@redhat.com, cohuck@redhat.com, mark.burton@greensocs.com, edgari@xilinx.com, qemu-s390x@nongnu.org, pbonzini@redhat.com, philmd@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/20/19 10:50 PM, Damien Hedde wrote: > Replace deprecated qbus_reset_all by resettable_cold_reset_fn for > the sysbus reset registration. > > Apart for the raspi machines, this does not impact the behavior > because: > + at this point resettable just calls the old reset methods of devices > and buses in the same order as qdev/qbus. > + resettable handlers registered with qemu_register_reset are > serialized; there is no interleaving. > + eventual explicit calls to legacy reset API (device_reset or > qdev/qbus_reset) inside this reset handler will not be masked out > by resettable mechanism; they do not go through resettable api. > > For the raspi machines, during the sysbus reset the sd-card is not > reset twice anymore but only once. This is a consequence of switching > both sysbus reset and changing parent to resettable; it detects the > second reset is not needed. This has no impact on the state after > reset; the sd-card reset method only reset local state and query > information from the block backend. > > Signed-off-by: Damien Hedde > Reviewed-by: Peter Maydell > --- Reviewed-by: Richard Henderson r~