* [PATCH] hw/bt: Remove empty Kconfig file
@ 2020-01-23 6:45 Thomas Huth
2020-02-06 9:59 ` Laurent Vivier
2020-02-06 11:38 ` Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2020-01-23 6:45 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
While removing the bluetooth code some weeks ago, I had to leave the
hw/bt/Kconfig file around. Otherwise some of the builds would have been
broken since the generated dependency files tried to include it before
they were rebuilt. Meanwhile, all those dependency files should have
been updated, so we can remove the empty Kconfig file now, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/bt/Kconfig | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 hw/bt/Kconfig
diff --git a/hw/bt/Kconfig b/hw/bt/Kconfig
deleted file mode 100644
index e69de29bb2..0000000000
--
2.18.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/bt: Remove empty Kconfig file
2020-01-23 6:45 [PATCH] hw/bt: Remove empty Kconfig file Thomas Huth
@ 2020-02-06 9:59 ` Laurent Vivier
2020-02-06 11:38 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-02-06 9:59 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial
Le 23/01/2020 à 07:45, Thomas Huth a écrit :
> While removing the bluetooth code some weeks ago, I had to leave the
> hw/bt/Kconfig file around. Otherwise some of the builds would have been
> broken since the generated dependency files tried to include it before
> they were rebuilt. Meanwhile, all those dependency files should have
> been updated, so we can remove the empty Kconfig file now, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/bt/Kconfig | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> delete mode 100644 hw/bt/Kconfig
>
> diff --git a/hw/bt/Kconfig b/hw/bt/Kconfig
> deleted file mode 100644
> index e69de29bb2..0000000000
>
Reviewed-by: Laurent Vivier <laurent@vivier.Eu>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/bt: Remove empty Kconfig file
2020-01-23 6:45 [PATCH] hw/bt: Remove empty Kconfig file Thomas Huth
2020-02-06 9:59 ` Laurent Vivier
@ 2020-02-06 11:38 ` Peter Maydell
2020-02-06 11:39 ` Thomas Huth
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2020-02-06 11:38 UTC (permalink / raw)
To: Thomas Huth; +Cc: QEMU Trivial, QEMU Developers
On Thu, 23 Jan 2020 at 06:46, Thomas Huth <thuth@redhat.com> wrote:
>
> While removing the bluetooth code some weeks ago, I had to leave the
> hw/bt/Kconfig file around. Otherwise some of the builds would have been
> broken since the generated dependency files tried to include it before
> they were rebuilt. Meanwhile, all those dependency files should have
> been updated, so we can remove the empty Kconfig file now, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
I ran this through my usual buildtests and they were all fine.
Tested-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/bt: Remove empty Kconfig file
2020-02-06 11:38 ` Peter Maydell
@ 2020-02-06 11:39 ` Thomas Huth
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2020-02-06 11:39 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Trivial, QEMU Developers
On 06/02/2020 12.38, Peter Maydell wrote:
> On Thu, 23 Jan 2020 at 06:46, Thomas Huth <thuth@redhat.com> wrote:
>>
>> While removing the bluetooth code some weeks ago, I had to leave the
>> hw/bt/Kconfig file around. Otherwise some of the builds would have been
>> broken since the generated dependency files tried to include it before
>> they were rebuilt. Meanwhile, all those dependency files should have
>> been updated, so we can remove the empty Kconfig file now, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>
> I ran this through my usual buildtests and they were all fine.
Finally! :-)
> Tested-by: Peter Maydell <peter.maydell@linaro.org>
Great, thanks for testing it again, Peter!
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-06 11:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-23 6:45 [PATCH] hw/bt: Remove empty Kconfig file Thomas Huth
2020-02-06 9:59 ` Laurent Vivier
2020-02-06 11:38 ` Peter Maydell
2020-02-06 11:39 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).