From: Thomas Huth <thuth@redhat.com>
To: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>, qemu-devel@nongnu.org
Cc: philmd@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de
Subject: Re: [Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use $() instead of ``)
Date: Mon, 22 Oct 2018 11:59:29 +0100 [thread overview]
Message-ID: <c3308f3b-50c4-2b15-f117-816ba326ef5f@redhat.com> (raw)
In-Reply-To: <20181022084824.555-3-maozhongyi@cmss.chinamobile.com>
On 2018-10-22 09:48, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete ``
> and modern $(); It would be nice to convert to using $()
> everywhere.
>
> Cc: philmd@redhat.com
> Cc: peter.maydell@linaro.org
> Cc: thuth@redhat.com
> Cc: sw@weilnetz.de
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
That last line should be "Reviewed-by:" instead - but that can be fixed
when the patch is picked up, no need to resend just because of this nit.
Thomas
next prev parent reply other threads:[~2018-10-22 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 8:48 [Qemu-devel] [PATCH v3 0/2] Modern shell scripting (use $() instead of ``) Mao Zhongyi
2018-10-22 8:48 ` [Qemu-devel] [PATCH v3 1/2] debian-bootstrap.pre: " Mao Zhongyi
2018-10-22 8:48 ` [Qemu-devel] [PATCH v3 2/2] po/Makefile: " Mao Zhongyi
2018-10-22 10:59 ` Thomas Huth [this message]
2018-10-22 13:05 ` [Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use $()instead " maozy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3308f3b-50c4-2b15-f117-816ba326ef5f@redhat.com \
--to=thuth@redhat.com \
--cc=maozhongyi@cmss.chinamobile.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).