From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEXw1-0004cs-SN for qemu-devel@nongnu.org; Mon, 22 Oct 2018 06:59:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEXvx-0002gR-PD for qemu-devel@nongnu.org; Mon, 22 Oct 2018 06:59:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54270) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gEXvx-0002eb-Gy for qemu-devel@nongnu.org; Mon, 22 Oct 2018 06:59:41 -0400 References: <20181022084824.555-1-maozhongyi@cmss.chinamobile.com> <20181022084824.555-3-maozhongyi@cmss.chinamobile.com> From: Thomas Huth Message-ID: Date: Mon, 22 Oct 2018 11:59:29 +0100 MIME-Version: 1.0 In-Reply-To: <20181022084824.555-3-maozhongyi@cmss.chinamobile.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use $() instead of ``) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mao Zhongyi , qemu-devel@nongnu.org Cc: philmd@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de On 2018-10-22 09:48, Mao Zhongyi wrote: > Various shell files contain a mix between obsolete `` > and modern $(); It would be nice to convert to using $() > everywhere. > > Cc: philmd@redhat.com > Cc: peter.maydell@linaro.org > Cc: thuth@redhat.com > Cc: sw@weilnetz.de > > Signed-off-by: Mao Zhongyi > Signed-off-by: Thomas Huth That last line should be "Reviewed-by:" instead - but that can be fixed when the patch is picked up, no need to resend just because of this nit. Thomas