[Qemu-devel] [PATCH v3 0/2] Modern shell scripting (use $() instead of ``)

[Qemu-devel] [PATCH v3 0/2] Modern shell scripting (use $() instead of ``)

[Mao Zhongyi]

Various shell files contain a mix between obsolete `` and
modern $(); It would be nice to convert to using $()
everywhere.

On https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02920.html

I just replaced `` in scripts dir,  so this series is a 
thorough cleanup of all obsolete `` in the source tree. 

v3:
-removed the patch1 from this series.  [Eric Blake]

v2:
-doubling "$" avoid it "escape" in a Makefile.  [Thomas Huth]

Cc: philmd@redhat.com
Cc: peter.maydell@linaro.org
Cc: thuth@redhat.com
Cc: sw@weilnetz.de
Cc: famz@redhat.com
Cc: eblake@redhat.com

Mao Zhongyi (2):
  debian-bootstrap.pre: Modern shell scripting (use $() instead of ``)
  po/Makefile: Modern shell scripting (use $() instead of ``)

 po/Makefile                                   | 2 +-
 tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.17.1

[Qemu-devel] [PATCH v3 1/2] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``)

[Mao Zhongyi]

Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.

Cc: alex.bennee@linaro.org
Cc: famz@redhat.com
Cc: philmd@redhat.com

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre b/tests/docker/dockerfiles/debian-bootstrap.pre
index 3b0ef95374..c164778c30 100755
--- a/tests/docker/dockerfiles/debian-bootstrap.pre
+++ b/tests/docker/dockerfiles/debian-bootstrap.pre
@@ -2,7 +2,7 @@
 #
 # Simple wrapper for debootstrap, run in the docker build context
 #
-FAKEROOT=`which fakeroot 2> /dev/null`
+FAKEROOT=$(which fakeroot 2> /dev/null)
 # debootstrap < 1.0.67 generates empty sources.list, see Debian#732255
 MIN_DEBOOTSTRAP_VERSION=1.0.67
 
@@ -52,7 +52,7 @@ fi
 
 if [ -z $DEBOOTSTRAP_DIR ]; then
     NEED_DEBOOTSTRAP=false
-    DEBOOTSTRAP=`which debootstrap 2> /dev/null`
+    DEBOOTSTRAP=$(which debootstrap 2> /dev/null)
     if [ -z $DEBOOTSTRAP ]; then
         echo "No debootstrap installed, attempting to install from SCM"
         NEED_DEBOOTSTRAP=true
-- 
2.17.1

[Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use $() instead of ``)

[Mao Zhongyi]

Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.

Cc: philmd@redhat.com
Cc: peter.maydell@linaro.org
Cc: thuth@redhat.com
Cc: sw@weilnetz.de

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 po/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/po/Makefile b/po/Makefile
index e47e262ee6..c041f4c858 100644
--- a/po/Makefile
+++ b/po/Makefile
@@ -36,7 +36,7 @@ clean:
 
 install: $(OBJS)
 	for obj in $(OBJS); do \
-	    base=`basename $$obj .mo`; \
+	    base=$$(basename $$obj .mo); \
 	    $(INSTALL) -d $(DESTDIR)$(prefix)/share/locale/$$base/LC_MESSAGES; \
 	    $(INSTALL) -m644 $$obj $(DESTDIR)$(prefix)/share/locale/$$base/LC_MESSAGES/qemu.mo; \
 	done
-- 
2.17.1

Re: [Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use $() instead of ``)

[Thomas Huth]

On 2018-10-22 09:48, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete ``
> and modern $(); It would be nice to convert to using $()
> everywhere.
> 
> Cc: philmd@redhat.com
> Cc: peter.maydell@linaro.org
> Cc: thuth@redhat.com
> Cc: sw@weilnetz.de
> 
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

That last line should be "Reviewed-by:" instead - but that can be fixed
when the patch is picked up, no need to resend just because of this nit.

 Thomas

Re: [Qemu-devel] [PATCH v3 2/2] po/Makefile: Modern shell scripting (use $()instead of ``)

[maozy]

On 10/22/18 6:59 PM, Thomas Huth wrote:
> On 2018-10-22 09:48, Mao Zhongyi wrote:
>> Various shell files contain a mix between obsolete ``
>> and modern $(); It would be nice to convert to using $()
>> everywhere.
>>
>> Cc: philmd@redhat.com
>> Cc: peter.maydell@linaro.org
>> Cc: thuth@redhat.com
>> Cc: sw@weilnetz.de
>>
>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> That last line should be "Reviewed-by:" instead - but that can be fixed
> when the patch is picked up, no need to resend just because of this nit.

OK, just because I didn't explicitly get R-b. :)

Thanks,
Mao

> 
>   Thomas
>