* [PATCH] hvf: Determine slot count from struct layout
@ 2021-10-08 5:46 Alexander Graf
2021-10-08 11:48 ` Richard Henderson
2021-10-08 17:18 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Graf @ 2021-10-08 5:46 UTC (permalink / raw)
To: QEMU Developers; +Cc: Roman Bolshakov, Cameron Esfahani
We can handle up to a static amount of memory slots, capped by the size of
an internal array.
Let's make sure that array size is the only source of truth for the number
of elements in that array.
Signed-off-by: Alexander Graf <agraf@csgraf.de>
---
accel/hvf/hvf-accel-ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c
index 6cbd2c3f97..2b2c411076 100644
--- a/accel/hvf/hvf-accel-ops.c
+++ b/accel/hvf/hvf-accel-ops.c
@@ -321,7 +321,7 @@ static int hvf_accel_init(MachineState *ms)
s = g_new0(HVFState, 1);
- s->num_slots = 32;
+ s->num_slots = ARRAY_SIZE(s->slots);
for (x = 0; x < s->num_slots; ++x) {
s->slots[x].size = 0;
s->slots[x].slot_id = x;
--
2.30.1 (Apple Git-130)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hvf: Determine slot count from struct layout
2021-10-08 5:46 [PATCH] hvf: Determine slot count from struct layout Alexander Graf
@ 2021-10-08 11:48 ` Richard Henderson
2021-10-08 17:18 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2021-10-08 11:48 UTC (permalink / raw)
To: Alexander Graf, QEMU Developers; +Cc: Roman Bolshakov, Cameron Esfahani
On 10/7/21 10:46 PM, Alexander Graf wrote:
> We can handle up to a static amount of memory slots, capped by the size of
> an internal array.
>
> Let's make sure that array size is the only source of truth for the number
> of elements in that array.
>
> Signed-off-by: Alexander Graf<agraf@csgraf.de>
> ---
> accel/hvf/hvf-accel-ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hvf: Determine slot count from struct layout
2021-10-08 5:46 [PATCH] hvf: Determine slot count from struct layout Alexander Graf
2021-10-08 11:48 ` Richard Henderson
@ 2021-10-08 17:18 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-10-08 17:18 UTC (permalink / raw)
To: Alexander Graf, QEMU Developers; +Cc: Roman Bolshakov, Cameron Esfahani
On 08/10/21 07:46, Alexander Graf wrote:
> We can handle up to a static amount of memory slots, capped by the size of
> an internal array.
>
> Let's make sure that array size is the only source of truth for the number
> of elements in that array.
>
> Signed-off-by: Alexander Graf <agraf@csgraf.de>
> ---
> accel/hvf/hvf-accel-ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c
> index 6cbd2c3f97..2b2c411076 100644
> --- a/accel/hvf/hvf-accel-ops.c
> +++ b/accel/hvf/hvf-accel-ops.c
> @@ -321,7 +321,7 @@ static int hvf_accel_init(MachineState *ms)
>
> s = g_new0(HVFState, 1);
>
> - s->num_slots = 32;
> + s->num_slots = ARRAY_SIZE(s->slots);
> for (x = 0; x < s->num_slots; ++x) {
> s->slots[x].size = 0;
> s->slots[x].slot_id = x;
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-08 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-08 5:46 [PATCH] hvf: Determine slot count from struct layout Alexander Graf
2021-10-08 11:48 ` Richard Henderson
2021-10-08 17:18 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).