From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egxIY-0000ON-6T for qemu-devel@nongnu.org; Wed, 31 Jan 2018 13:39:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egxIX-0007qm-6T for qemu-devel@nongnu.org; Wed, 31 Jan 2018 13:39:54 -0500 References: <20180119224735.12169-1-jsnow@redhat.com> <086ccaa6-eefb-47e4-a865-78075ddd827d@redhat.com> From: John Snow Message-ID: Date: Wed, 31 Jan 2018 13:39:48 -0500 MIME-Version: 1.0 In-Reply-To: <086ccaa6-eefb-47e4-a865-78075ddd827d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] file-posix: specify expected filetypes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org ping On 01/19/2018 06:03 PM, Eric Blake wrote: > On 01/19/2018 04:47 PM, John Snow wrote: >> Adjust each caller of raw_open_common to specify if they are expecting >> host and character devices or not. Tighten expectations of file types upon >> open in the common code and refuse types that are not expected. >> >> This has two effects: >> >> (1) Character and block devices are now considered deprecated for the >> 'file' driver, which expects only S_IFREG, and >> (2) no file-posix driver (file, host_cdrom, or host_device) can open >> directories now. >> >> I don't think there's a legitimate reason to open directories as if >> they were files. This prevents QEMU from opening and attempting to probe >> a directory inode, which can break in exciting ways. One of those ways >> is lseek on ext4/xfs, which will return 0x7fffffffffffffff as the file >> size instead of EISDIR. This can coax QEMU into responding with a >> confusing "file too big" instead of "Hey, that's not a file". >> >> See: https://bugs.launchpad.net/qemu/+bug/1739304/ >> Signed-off-by: John Snow >> --- > > Reviewed-by: Eric Blake >