Re: [PATCH] meson: Display summary of Darwin libraries detected

[Paolo Bonzini <pbonzini@redhat.com>]

On 2/12/25 12:29, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   meson.build | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 18cf9e2913b..10f4c9fd30d 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4826,6 +4826,13 @@ summary_info += {'libdw':             libdw}
>   if host_os == 'freebsd'
>     summary_info += {'libinotify-kqueue': inotify}
>   endif
> +if host_os == 'darwin'
> +  summary_info += {'Hypervisor support': hvf}
> +  summary_info += {'CoreFoundation support': coref}
> +  summary_info += {'IOKit support': iokit}
> +  summary_info += {'ParavirtualizedGraphics support': pvg}
> +  summary_info += {'Metal support': metal}
> +endif
I think all of these are going to be present anyway, because they're 
mandatory (except IOKit which _is_ going to be there, and HVF which is 
present elsewhere) and there's no version indication for Apple frameworks.

However, adding pvg and metal here makes sense if:

- "config PVG" is added to Kconfig.host with the corresponding 
assignment to host_kconfig

- "depends on PVG" is added to "config MAC_PVG"

- after which, host_os = "darwin" is not needed anymore in 
hw/display/meson.build

Also, it's not clear to me if PVG can also work with TCG, and therefore 
the MMIO version can be used on x86 Macs?  If so the 'if cpu = 
"aarch64"' in hw/display/meson.build seems wrong.

Either way, the Kconfig file does not need "depends on AARCH64" and it 
should have just

     depends on MAC_PVG

with an "imply" somewhere in hw/arm/Kconfig.

Paolo