From: Thomas Huth <thuth@redhat.com>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 2/3] accel/tcg: Add debuginfo support
Date: Mon, 30 Jan 2023 15:33:18 +0100 [thread overview]
Message-ID: <c341f40c-59f6-754b-1323-b3343ee40cad@redhat.com> (raw)
In-Reply-To: <20230112152013.125680-3-iii@linux.ibm.com>
On 12/01/2023 16.20, Ilya Leoshkevich wrote:
> Add libdw-based functions for loading and querying debuginfo. Load
> debuginfo from the system and the linux-user loaders.
>
> This is useful for the upcoming perf support, which can then put
> human-readable guest symbols instead of raw guest PCs into perfmap and
> jitdump files.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
...
> diff --git a/meson.build b/meson.build
> index 175517eafde..cab8c67d961 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1648,6 +1648,12 @@ if libbpf.found() and not cc.links('''
> endif
> endif
>
> +# libdw
> +libdw = dependency('libdw',
> + method: 'pkg-config',
> + kwargs: static_kwargs,
> + required: false)
> +
Hi,
I recently did a build with "configure --without-default-features" and I
noticed that this new libdw does not get disabled automatically there, which
looks kind of weird. Is there a reason that there is no config knob here to
disable it like we have it with all the other optional libraries that we
support?
Thomas
next prev parent reply other threads:[~2023-01-30 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 15:20 [PATCH v4 0/3] tcg: add perfmap and jitdump Ilya Leoshkevich
2023-01-12 15:20 ` [PATCH v4 1/3] linux-user: Clean up when exiting due to a signal Ilya Leoshkevich
2023-01-12 15:20 ` [PATCH v4 2/3] accel/tcg: Add debuginfo support Ilya Leoshkevich
2023-01-30 14:33 ` Thomas Huth [this message]
2023-01-30 14:43 ` Ilya Leoshkevich
2023-01-12 15:20 ` [PATCH v4 3/3] tcg: add perfmap and jitdump Ilya Leoshkevich
2023-01-14 1:05 ` [PATCH v4 0/3] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c341f40c-59f6-754b-1323-b3343ee40cad@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).