From: Hanna Czenczek <hreitz@redhat.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, den@virtuozzo.com
Subject: Re: [PATCH 3/6] qemu-img: rebase: use backing files' BlockBackend for buffer alignment
Date: Fri, 25 Aug 2023 16:29:08 +0200 [thread overview]
Message-ID: <c348e12f-4667-3459-ef2c-86b514456132@redhat.com> (raw)
In-Reply-To: <20230601192836.598602-4-andrey.drobyshev@virtuozzo.com>
On 01.06.23 21:28, Andrey Drobyshev via wrote:
> Since commit bb1c05973cf ("qemu-img: Use qemu_blockalign"), buffers for
> the data read from the old and new backing files are aligned using
> BlockDriverState (or BlockBackend later on) referring to the target image.
> However, this isn't quite right, because target image is only being
> written to and has nothing to do with those buffers. Let's fix that.
I don’t understand. The write to the target image does use one of those
buffers (buf_old, specifically).
This change is correct for buf_new/blk_new_backing, but for buf_old, in
theory, we need a buffer that fulfills both the alignment requirements
of blk and blk_old_backing. (Not that this patch really makes the
situation worse for buf_old.)
Hanna
next prev parent reply other threads:[~2023-08-25 14:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 19:28 [PATCH 0/6] qemu-img: rebase: add compression support Andrey Drobyshev via
2023-06-01 19:28 ` [PATCH 1/6] qemu-img: rebase: stop when reaching EOF of old backing file Andrey Drobyshev via
2023-06-01 21:18 ` Michael Tokarev
2023-06-02 10:47 ` Andrey Drobyshev
2023-06-21 18:23 ` Denis V. Lunev
2023-08-25 14:29 ` Hanna Czenczek
2023-10-26 6:32 ` Michael Tokarev
2023-10-26 8:16 ` Andrey Drobyshev
2023-06-01 19:28 ` [PATCH 2/6] qemu-iotests: 024: add rebasing test case for overlay_size > backing_size Andrey Drobyshev via
2023-06-21 18:23 ` Denis V. Lunev
2023-08-25 14:29 ` Hanna Czenczek
2023-06-01 19:28 ` [PATCH 3/6] qemu-img: rebase: use backing files' BlockBackend for buffer alignment Andrey Drobyshev via
2023-06-21 18:16 ` Denis V. Lunev
2023-08-25 14:29 ` Hanna Czenczek [this message]
2023-08-29 7:06 ` Andrey Drobyshev
2023-08-29 8:44 ` Hanna Czenczek
2023-06-01 19:28 ` [PATCH 4/6] qemu-img: rebase: avoid unnecessary COW operations Andrey Drobyshev via
2023-06-21 18:53 ` Denis V. Lunev
2023-08-25 15:00 ` Hanna Czenczek
2023-08-29 13:27 ` Andrey Drobyshev
2023-06-01 19:28 ` [PATCH 5/6] qemu-img: add compression option to rebase subcommand Andrey Drobyshev via
2023-06-21 18:22 ` Denis V. Lunev
2023-08-25 15:14 ` Hanna Czenczek
2023-06-01 19:28 ` [PATCH 6/6] iotests: add test 314 for "qemu-img rebase" with compression Andrey Drobyshev via
2023-06-21 19:16 ` Denis V. Lunev
2023-08-25 15:17 ` Hanna Czenczek
2023-06-30 10:54 ` [PATCH 0/6] qemu-img: rebase: add compression support Denis V. Lunev
2023-07-07 11:33 ` Andrey Drobyshev
2023-07-24 13:11 ` Andrey Drobyshev
2023-07-31 14:43 ` Andrey Drobyshev
2023-08-16 9:22 ` Andrey Drobyshev
2023-08-22 17:35 ` Andrey Drobyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c348e12f-4667-3459-ef2c-86b514456132@redhat.com \
--to=hreitz@redhat.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).