From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] configure / meson: Move the GBM handling to meson.build
Date: Wed, 14 Jul 2021 09:12:44 +0200 [thread overview]
Message-ID: <c36de5d8-43fb-4e09-9712-1ab1c2c6734a@redhat.com> (raw)
In-Reply-To: <fbc46ce8-511f-65eb-fa62-aa123bfb0562@redhat.com>
On 13/07/2021 14.29, Paolo Bonzini wrote:
> On 13/07/21 13:15, Thomas Huth wrote:
>> The GBM library detection does not need to be in the configure script,
>> since it does not have any user-facing options (there are no
>> --enable-gbm or --disable-gbm switches). Let's move it to meson.build
>> instead, so we don't have to clutter config-host.mak with the related
>> switches.
>>
>> Additionally, only check for GBM if it is really required, i.e. if we
>> either compile with OpenGL or with virglrenderer support.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Queued, thanks.
Drat, sorry, I sent it out too early, one of the CI pipelines finally failed:
https://gitlab.com/thuth/qemu/-/jobs/1420060624#L100
... thus please drop it again, I have to fix that first.
Thomas
next prev parent reply other threads:[~2021-07-14 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 11:15 [PATCH] configure / meson: Move the GBM handling to meson.build Thomas Huth
2021-07-13 12:29 ` Paolo Bonzini
2021-07-14 7:12 ` Thomas Huth [this message]
2021-07-14 8:52 ` Thomas Huth
2021-07-14 10:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36de5d8-43fb-4e09-9712-1ab1c2c6734a@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).