From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11AD3C07E9A for ; Wed, 14 Jul 2021 07:13:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D2B3613AA for ; Wed, 14 Jul 2021 07:13:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D2B3613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3Z5K-0000lD-LJ for qemu-devel@archiver.kernel.org; Wed, 14 Jul 2021 03:13:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Z4h-0008Vb-Vz for qemu-devel@nongnu.org; Wed, 14 Jul 2021 03:12:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Z4e-0007jL-Ma for qemu-devel@nongnu.org; Wed, 14 Jul 2021 03:12:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626246770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P+fTqVyHlLvS/WPDBFIIzpgIP2K97m1saNNc5Y2XsZk=; b=P6JvltZY0yEjWMK29t2EjIQ1YbpKlXEeJ3FS9aGw/gf9atJyBGSjufA6vfQAEIIbEMph7Y DJ+1oh5zGnNW7I+5Y4NNZ8R3A75Ram5eh3p0gRxqQOvKGZmrDBBHrYvawVLpwDOoZDPd2T RqUfejfNZAcQ3R/li1vMPP+0IRe2xYc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-M7aG_hlNPja5GbPaQUG3lw-1; Wed, 14 Jul 2021 03:12:47 -0400 X-MC-Unique: M7aG_hlNPja5GbPaQUG3lw-1 Received: by mail-wr1-f70.google.com with SMTP id y15-20020a5d614f0000b029013cd60e9baaso1001343wrt.7 for ; Wed, 14 Jul 2021 00:12:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P+fTqVyHlLvS/WPDBFIIzpgIP2K97m1saNNc5Y2XsZk=; b=aW4Ph6BQDbwnhqAcpw6v6q8ww/jw6RbSp3AtQkFqi44bACTl5LsgFTlx8Byn8UUnF3 hrklyOpgUn5XdM6Nz2gwnjAqn9P8gumQ/u2seX9YQOfjliI7TkqV26hK67s5CxUBCAGR TyYMFm4nPDAsdnoAOzaP02W2QuJNHI+tdTQ2i70khwzSlcuE7NNrloUaSvWfuPtnwehS J+Y8AlwuSSFaqCML7K8+yPM8COEdrqCrynKSxGhI/Kgro/SOTmVSqlldmxb0rhlZQDoG Xhht+GX8BTis/gxF5aZnXm/mqwyfeRBaWUnaPArzJ+5nDWtTPR56380vtRCbakbOHDvi XuBg== X-Gm-Message-State: AOAM530D+ZH9gqFJ2HiXFdNHj1CfU38fuPuN8c5EXxfixD/RwZWY8Q9d KwNJ4g4mlaRceLFbbc59oeu4tqec/vIFIUWBkbBSjM/RIwjOeonz/NYP+JcZKSSqDhI4UMhV+gS Mpps3Kjg2mGTzw7k= X-Received: by 2002:a5d:53c5:: with SMTP id a5mr11127727wrw.15.1626246766644; Wed, 14 Jul 2021 00:12:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/ktsxKQkahf7/+lxqXI5n60nAhN7Q6yHMOEViaVf1N+hisqhFXYkhVtjNcwXsAaxm3cTFNg== X-Received: by 2002:a5d:53c5:: with SMTP id a5mr11127701wrw.15.1626246766405; Wed, 14 Jul 2021 00:12:46 -0700 (PDT) Received: from thuth.remote.csb (pd9e83a2f.dip0.t-ipconnect.de. [217.232.58.47]) by smtp.gmail.com with ESMTPSA id s24sm1568108wra.33.2021.07.14.00.12.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jul 2021 00:12:45 -0700 (PDT) Subject: Re: [PATCH] configure / meson: Move the GBM handling to meson.build To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210713111516.734834-1-thuth@redhat.com> From: Thomas Huth Message-ID: Date: Wed, 14 Jul 2021 09:12:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.368, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 13/07/2021 14.29, Paolo Bonzini wrote: > On 13/07/21 13:15, Thomas Huth wrote: >> The GBM library detection does not need to be in the configure script, >> since it does not have any user-facing options (there are no >> --enable-gbm or --disable-gbm switches). Let's move it to meson.build >> instead, so we don't have to clutter config-host.mak with the related >> switches. >> >> Additionally, only check for GBM if it is really required, i.e. if we >> either compile with OpenGL or with virglrenderer support. >> >> Signed-off-by: Thomas Huth > > Queued, thanks. Drat, sorry, I sent it out too early, one of the CI pipelines finally failed: https://gitlab.com/thuth/qemu/-/jobs/1420060624#L100 ... thus please drop it again, I have to fix that first. Thomas