From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Fabian Vogt <fvogt@suse.de>, Harsh Prateek Bora <harshpb@linux.ibm.com>
Cc: qemu-ppc@nongnu.org, Nicholas Piggin <npiggin@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH-for-10.1] hw/intc/xics: Add missing call to register vmstate_icp_server
Date: Thu, 14 Aug 2025 13:44:16 +0200 [thread overview]
Message-ID: <c37f5d33-bcf3-4553-b6ce-c11b3e6c3d99@linaro.org> (raw)
In-Reply-To: <6187781.lOV4Wx5bFT@fvogt-thinkpad>
On 14/8/25 13:35, Fabian Vogt wrote:
> An obsolete wrapper function with a workaround was removed entirely,
> without restoring the call it wrapped.
>
> Without this, the guest is stuck after savevm/loadvm.
>
> Fixes: 24ee9229fe31 ("ppc/spapr: remove deprecated machine pseries-2.9")
> Signed-off-by: Fabian Vogt <fvogt@suse.de>
> ---
> hw/intc/xics.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index d9a199e883..200710eb6c 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -335,6 +335,8 @@ static void icp_realize(DeviceState *dev, Error **errp)
> return;
> }
> }
> +
> + vmstate_register(NULL, icp->cs->cpu_index, &vmstate_icp_server, icp);
> }
>
> static void icp_unrealize(DeviceState *dev)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-08-14 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 11:35 [PATCH] hw/intc/xics: Add missing call to register vmstate_icp_server Fabian Vogt
2025-08-14 11:44 ` Philippe Mathieu-Daudé [this message]
2025-08-19 2:55 ` Fabiano Rosas
2025-08-19 7:29 ` Harsh Prateek Bora
2025-08-19 15:07 ` Miles Glenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c37f5d33-bcf3-4553-b6ce-c11b3e6c3d99@linaro.org \
--to=philmd@linaro.org \
--cc=fvogt@suse.de \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).