From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6757C4338F for ; Mon, 9 Aug 2021 08:28:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34D0161004 for ; Mon, 9 Aug 2021 08:28:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34D0161004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD0do-0003MS-1P for qemu-devel@archiver.kernel.org; Mon, 09 Aug 2021 04:28:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD0cy-0002X1-39 for qemu-devel@nongnu.org; Mon, 09 Aug 2021 04:27:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD0cw-0003LK-PE for qemu-devel@nongnu.org; Mon, 09 Aug 2021 04:27:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628497637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jfDID35EIXJ3a3KKJlLXmA9iPbY5wgLmoCdkrNDHUp0=; b=cPhqBlR4as8uKYFBbcgoUXkdWj9T10K6mO8rdpGUeRrqLcNLyz8xHm39o0AxGnNUbXKDNK nnWaiLzBIzktq58uPCmOUTjxb2rtOm4139XtLTkirUwaYOXEeHRnsO17ZveoG7a9upFL1O 0Du+cAnFkG1AACWdz9lbce5fYFELOO0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-tHmDOKq4NrmYYYFc56FqtA-1; Mon, 09 Aug 2021 04:27:16 -0400 X-MC-Unique: tHmDOKq4NrmYYYFc56FqtA-1 Received: by mail-wm1-f71.google.com with SMTP id k5-20020a7bc3050000b02901e081f69d80so3800253wmj.8 for ; Mon, 09 Aug 2021 01:27:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jfDID35EIXJ3a3KKJlLXmA9iPbY5wgLmoCdkrNDHUp0=; b=UoV5m8kKT8mBa4bO1f2TzeXUQ/hcaWFQ7RMF/b/kAtEqQQJ0fjfSBMGBS4GzFEknIH Sm4Isnq28Siy+Raze1smg5ddZhBOrBchfYPDL1r6U5vWIflYFskNqF6vJ1Iz3WLWzg0l TiXXFYtWfpl20PiDqF/t8+FgunMUGZBuWH/CDu1aBUGZB84k2E6lOw1NWwCkk9nxsPwg UvEa5GM1do4Hy6qWfi9WM4rgaHuGHXCg57TyHplWI/cHwtkqnF5Lq0Gv4FuNmlVYFMs9 2/tYFFeLpFPimmlkdvYOIDkllND/XP23M6bOCTECqBfWaTd125DwiTIQHvF9fooJjWUS b4vw== X-Gm-Message-State: AOAM533ZdvujQPepjh0d/WhvPvDHFZcfLhoegPw5v2pnvDCTe8kATWXP UGpOCcIdrVldfctw0GUOLbmewbAw6OzInRYAK45zc9dlvOU0L4X3fdtrwMeaaQbTr4qw9Q2mWC0 efPZJLfMd8j0jIGp6HpPmnSwlLPJ/vZu6iXg9LUkaj3MHxU0J3UjkH+C3D+XeJWP6v+s= X-Received: by 2002:a1c:7c10:: with SMTP id x16mr15473649wmc.41.1628497635111; Mon, 09 Aug 2021 01:27:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL/1VGhY9vNFEh+RCqDTJJQOjB1YDnuPCrvMCBxcyw1x4z7u8JIQuTybPP6Mgy0J79YTzYwA== X-Received: by 2002:a1c:7c10:: with SMTP id x16mr15473616wmc.41.1628497634870; Mon, 09 Aug 2021 01:27:14 -0700 (PDT) Received: from localhost.localdomain ([2a04:ee41:4:31cb:e591:1e1e:abde:a8f1]) by smtp.gmail.com with ESMTPSA id n10sm1435137wmq.3.2021.08.09.01.27.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 01:27:14 -0700 (PDT) Subject: Re: [PATCH v8 08/16] qemu-iotests: add gdbserver option to script tests too To: Max Reitz , qemu-block@nongnu.org References: <20210705065711.127119-1-eesposit@redhat.com> <20210705065711.127119-9-eesposit@redhat.com> <647d146b-96dc-48f0-054b-97fc6fb181a4@redhat.com> From: Emanuele Giuseppe Esposito Message-ID: Date: Mon, 9 Aug 2021 10:27:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <647d146b-96dc-48f0-054b-97fc6fb181a4@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.707, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-devel@nongnu.org, Cleber Rosa , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" >> diff --git a/tests/qemu-iotests/common.qemu >> b/tests/qemu-iotests/common.qemu >> index 0fc52d20d7..cbca757b49 100644 >> --- a/tests/qemu-iotests/common.qemu >> +++ b/tests/qemu-iotests/common.qemu >> @@ -85,7 +85,12 @@ _timed_wait_for() >>       timeout=yes >>       QEMU_STATUS[$h]=0 >> -    while IFS= read -t ${QEMU_COMM_TIMEOUT} resp <&${QEMU_OUT[$h]} >> +    read_timeout="-t ${QEMU_COMM_TIMEOUT}" >> +    if [ ! -z ${GDB_OPTIONS} ]; then > > Shouldn’t we quote "${GDB_OPTIONS}" so that `test` won’t interpret it as > its own parameters (if something in there starts with `--`, which I > don’t think is the intended usage for $GDB_OPTIONS, but, well...)? > > (Also, `! -z` is the same as `-n`, but I suppose choosing between the > two can be a matter of style.) > >> + >> +        GDB="" >> +        if [ ! -z ${GDB_OPTIONS} ]; then > > Here, too.  (Sorry for not noticing in v3 already...) Sorry, I forgot to reply to this email. I agree, I will put quotes and change `! -z` in `-n`. I will send v9 because after all this time this serie has some minor conflicts with current QEMU version. Hopefully this will be the last one :) Thank you, Emanuele