From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B779C433E1 for ; Fri, 24 Jul 2020 16:33:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9484206D8 for ; Fri, 24 Jul 2020 16:33:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XFdAKR9M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9484206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jz0d2-00078i-W2 for qemu-devel@archiver.kernel.org; Fri, 24 Jul 2020 12:33:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jz0bl-0006B0-Hs for qemu-devel@nongnu.org; Fri, 24 Jul 2020 12:31:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:22767 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jz0bj-0000M8-N9 for qemu-devel@nongnu.org; Fri, 24 Jul 2020 12:31:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595608298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+KTu+vO6JVu5c6Fxz88AdgitKcMBCtJ1d/rXs0pU0Q=; b=XFdAKR9Me7ST3fxankI1kD+0SoMeuYrLJwnfPCmgpILfWXYg12uXltZ3VJ100BL7WCvLlN 2Q9yktwYwYU1zmtv2KkawPOjEcZW8jmRrZNG1JiUtA4R8jHsKdZ4agKwY50qzLP8uunmNh iTuVop/in+8/MK/bb2qyBq20Z8khF84= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-6T2Jx2C3P_qAT4owuTK3QA-1; Fri, 24 Jul 2020 12:31:34 -0400 X-MC-Unique: 6T2Jx2C3P_qAT4owuTK3QA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53BD4800C64; Fri, 24 Jul 2020 16:31:28 +0000 (UTC) Received: from ibm-p8-OVS-01-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com (ovpn-120-206.rdu2.redhat.com [10.10.120.206]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA3287269F; Fri, 24 Jul 2020 16:31:26 +0000 (UTC) Subject: Re: [PATCH 1/1] python/machine: Change default timeout to 30 seconds To: Peter Maydell References: <20200720160252.104139-1-jsnow@redhat.com> <20200720160252.104139-2-jsnow@redhat.com> <20200720202038.GZ1274972@habkost.net> From: John Snow Message-ID: Date: Fri, 24 Jul 2020 12:31:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200720202038.GZ1274972@habkost.net> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=jsnow@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/24 08:55:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/20/20 4:20 PM, Eduardo Habkost wrote: > On Mon, Jul 20, 2020 at 12:02:52PM -0400, John Snow wrote: >> 3 seconds is too short for some tests running inside busy VMs. Build it out to >> a rather generous 30 seconds to find out conclusively if there are more severe >> problems in the merge/CI tests. >> >> Signed-off-by: John Snow > > It's weird how the hard shutdown method has a more graceful > timeout than graceful shutdown (60 seconds vs 3 seconds). > > I would make both have the same timeout, but it's better to try > this only after 5.1.0. > > Reviewed-by: Eduardo Habkost > > Peter, do you want to take this directly to see if it starts to fix the merge tests for you? It extends the shutdown timeout from 3 to 30 seconds. If it still hangs at 30 seconds, I think there's clearly something much worse going on that will need to be investigated. --js