From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58B46CD8C9B for ; Thu, 13 Nov 2025 16:12:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vJZvY-0002LN-AH; Thu, 13 Nov 2025 11:12:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJZuy-0001kf-LY for qemu-devel@nongnu.org; Thu, 13 Nov 2025 11:11:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJZux-00014i-94 for qemu-devel@nongnu.org; Thu, 13 Nov 2025 11:11:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763050286; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kuxBfdu6kY0KdaWE7A2OKXKhFmTlP7+laG2mTLCscIE=; b=RgnF8Hw6EWPR7yCwetzrCPWhSKHV6iEtsahPJNcMS4UGhDZateXUW7F75paPHFQD+rF9PK MA5XsO5/75XmP1QkF+r9vLjbM4F1/6CNMjeqa8jK3NpX4PgdzJodIjrPA6BYzkT8PyfXcQ ac9ruatd00uQuON+G59NBM42XrQ8oA4= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-zC2zo1qhNWq4rrImWfACkw-1; Thu, 13 Nov 2025 11:11:24 -0500 X-MC-Unique: zC2zo1qhNWq4rrImWfACkw-1 X-Mimecast-MFC-AGG-ID: zC2zo1qhNWq4rrImWfACkw_1763050284 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8a9ec099b5cso282975485a.1 for ; Thu, 13 Nov 2025 08:11:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763050284; x=1763655084; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kuxBfdu6kY0KdaWE7A2OKXKhFmTlP7+laG2mTLCscIE=; b=gN/ojZ1n4nq2r0pB1cvn5Zi6z+TQTMLw7y859oyEPZIA/A9dzv6gnatTDoB0hXQ/qy 8fyMcb8iXbstImbFS1Erekr0r1s2jeq2rVGsYaSY2s09Oqpv8Td8ArzeiKD/rOe3FbDU +tN+8xXNVPPsfnFjkZ2BB8PSguoeRGSqPtAMzgKJfR3ZWRDg52v/HmeJPlqpDFvXes3C L6/so72viU7OZqNoYldy+IHsOte+aa/BNUUXciNfgy95gWurG/3kvSMLKi1N0ycykvoo 6r/HoNVgXBJoYOXVKcyvy3AxsHNOS0WhylyuOjISD3yTW5TLoLgVoYaNsbSDq0YT+Gm1 DAng== X-Forwarded-Encrypted: i=1; AJvYcCVD4iw8oU7RNmbBndzmQcqoGZJeoMtT5ccZkHMVWxRADvcrLvKO0tOfjHpgN1oI96dwPJS6gRz/ZJw0@nongnu.org X-Gm-Message-State: AOJu0YwjtOvfwTPUxgLCpJ9e4/3+QNOPbXnBfdAS79smt1VkixU1lHwQ gYA48RPwnjnbM5RiLciy+BICXw/2Qx8O6AwvvaI25gC6vXP1zMNm7rWAbyVgwzFgLby5IEDG8yW ExiEkNf/eqx7A8DZKavoGnV5NuPI5B5TDKI3Ai1B9jFmcbGMOUvgZ9KDI X-Gm-Gg: ASbGncseoAfGR/OVdoViasJfw36Ot93EFUUG5wzK986r6sQvv4YxtYWIWhVitZxeAgM 7z105Eo9e5DOvATK0ioE5H5K1Ykm03L610ezvgNDVET2BDZrsKhnKv7cLs1+S4iEMAuK8RG5uQU J1WNDF0UrxfXOWGBvMCpQLUWSfJr4fWPkxZntOlCnt9flApgLQFmVCg6j0TwHkztP22w57/T543 BfUGoklvbsWEm9bQfS5ZMS28hU6flvfIWsPOjIw3Jcn4B+YS+9whuKqqfRhsflfNYi5VRnqjJXM Lc1O3c2/iD1V9f+C6jLYgFMFYabWAuBctZEMzRdVlkzZbjn4iGVpFgoSdGF9QlvTfgH3lDhB9eN yASfneyLTVIVbO3eyNy9P+cqnKYtokmyKaLqvkloOBtuzDA== X-Received: by 2002:a05:620a:4726:b0:8b1:be0f:da52 with SMTP id af79cd13be357-8b29b76cb38mr964928985a.7.1763050284352; Thu, 13 Nov 2025 08:11:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+YhppjKRVYtghjQNQUOILcFalSAKjrwgJUOiVYlATXBb8dSR3XEP2h1zxVAWnf68zVXrisw== X-Received: by 2002:a05:620a:4726:b0:8b1:be0f:da52 with SMTP id af79cd13be357-8b29b76cb38mr964921585a.7.1763050283791; Thu, 13 Nov 2025 08:11:23 -0800 (PST) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2aeeb1487sm156162385a.19.2025.11.13.08.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Nov 2025 08:11:23 -0800 (PST) Message-ID: Date: Thu, 13 Nov 2025 17:11:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH 1/7] target/arm/machine: Improve traces on register mismatch during migration Content-Language: en-US To: Peter Maydell , Cornelia Huck Cc: eric.auger.pro@gmail.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, maz@kernel.org, oliver.upton@linux.dev, sebott@redhat.com, gshan@redhat.com, ddutile@redhat.com, peterx@redhat.com, philmd@linaro.org, pbonzini@redhat.com References: <20251016140039.250111-1-eric.auger@redhat.com> <20251016140039.250111-2-eric.auger@redhat.com> <877bwtvaj7.fsf@redhat.com> <791e0383-c4c7-49bf-863c-d45428f3e48d@redhat.com> <874iqyrnt3.fsf@redhat.com> From: Eric Auger In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/13/25 4:01 PM, Peter Maydell wrote: > On Thu, 13 Nov 2025 at 14:48, Cornelia Huck wrote: >> On Thu, Nov 13 2025, Eric Auger wrote: >> >>>>> + #define MAX_CPREG_VMSTATE_ANOMALIES 10 >>>>> + uint64_t cpreg_vmstate_missing_indexes[MAX_CPREG_VMSTATE_ANOMALIES]; >>>>> + int32_t cpreg_vmstate_missing_indexes_array_len; >>>>> + uint64_t cpreg_vmstate_unexpected_indexes[MAX_CPREG_VMSTATE_ANOMALIES]; >>>>> + int32_t cpreg_vmstate_unexpected_indexes_array_len; >>>> "indices"? >>> Originally we had >>> uint64_t *cpreg_vmstate_indexes; >>> so I reused the same terminology >>> >>> As a non native english speaker I don't know if the usage is wrong. I >>> thought some references on the net though >> Not a native English speaker, either; wiktionary says both are valid, so >> probably a matter of taste. > Mmm. I tend to go with "indexes" as being clearer (especially > for non-native speakers) than "indices". Within QEMU sources > there are twice as many "indexes" as "indices". OK thanks. I will keep it. Eric > > thanks > -- PMM >