From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A5F7C77B7C for ; Wed, 25 Jun 2025 07:14:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uUKJj-0006VB-I4; Wed, 25 Jun 2025 03:13:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uUKJe-0006Uh-8g for qemu-devel@nongnu.org; Wed, 25 Jun 2025 03:13:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uUKJY-00085A-RF for qemu-devel@nongnu.org; Wed, 25 Jun 2025 03:13:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750835577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g0OtH3O7UqLVpfgv2lD26Fv6iialFDGd7dCIk351wvo=; b=P5oNWjgT2jG2W6ol9Ab74ZPnra0TaoojuT40dx8IdCX5xs6QG7zwTw88TrtdRY+cbAHiG5 WJLdzeeLCVehDW1Xc7mJ1bmAgnA2yeycnl7QTw+Ll4mYf9X7ByGHM2GUrS15RHeRzRWh4Y 1cgmvMH7Eb9icqjB49dpd44+KajgsYw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-PMaFUHhEOzG-6PVg4qGsEA-1; Wed, 25 Jun 2025 03:12:55 -0400 X-MC-Unique: PMaFUHhEOzG-6PVg4qGsEA-1 X-Mimecast-MFC-AGG-ID: PMaFUHhEOzG-6PVg4qGsEA_1750835574 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4f3796779so638404f8f.1 for ; Wed, 25 Jun 2025 00:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750835574; x=1751440374; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g0OtH3O7UqLVpfgv2lD26Fv6iialFDGd7dCIk351wvo=; b=pWXwrbj7HcRyv2sce/jOndUfXc1awK7CCil3OO7N8JBajSnfmMtS1se9OWgIzjQ2cL cbqsK9NQbuOkcWuX13M0gbcG5AxQPbow0U0aYQwAjihSJXTKRI0vJVDVj2LZoGp19RVH MIeKm+oEgU7s6X6FThq1pS8aq2EZi1QXsBqvX4NcBnaD//2MlOcSBaO0mKuX4lOMUJIe IOET9zc7qz0L14HRlkyVS/ecfAihyd4ML/DWP9wcojiFAxtLRLka4CPaH629ldLimwwI BmlKmGbFUESEJLg/t2vGywByxtIjNSzvyonb5+AfFa1VZO/Vq3qU3TdsdGHVTnXp8qIw AWPA== X-Forwarded-Encrypted: i=1; AJvYcCVc6SRlzxFopae8RZHAVQ4DIkuIEpPUA01KhJVnQBNKzRu6UFQfzJovGIXVBh1rz6Sp+fnyFRVV+pz1@nongnu.org X-Gm-Message-State: AOJu0YzbPh74FiJPahiDZtjbmQEbs0U3gultE5hMCNGFzrF0mMAd4TGu NGdlEkvJhDBWSEnc+m3opE8byhmMSiVwDUPH+jZu0bvFkGvlcDn8D8tcdeSijjMBUiNn/ZbgnKR edEVqeDYlvHnFXm1q/PdWRhzWkyimZ0FiHWHiT9iOEwV4dhMS/cjoHHrc X-Gm-Gg: ASbGncsG3jDiinMoWZsAwoxCE+3psvveF9BecKCj1WJlvTho1KX2feZhGHKzsWff9MX StbJSwaB5YxOlvS8F7GTIXb4Vng8jWeMxxht6IcF4XGQBL9wqEppLZZ0UwSngFzn7+G5nxHRuue JR+bnMhGH/to8JZynko5ivgmHo9sZmWoVxYIzZRz+kjbxufLnVed4o7Vrv89bAa6wDixvM4yadv a3ePvKOt7zFuxRWn0Tr9YtI6yNf1ZYEpJpBJLKwrg6/vGq4A6qstiAMz+BLQ1wVyEPZAKX44jXn CCfqC1PAXo977kccIOsMkQDMakGWNEJf892VMG8Pcx2T+0Km7gEWPUMQa/A9 X-Received: by 2002:a05:6000:42ca:b0:3a5:1222:ac64 with SMTP id ffacd0b85a97d-3a6ed63864emr725948f8f.38.1750835574107; Wed, 25 Jun 2025 00:12:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDI3wC/h8w7Cm9VfG7ib6EWmF6b8LXDFeayJrUH3ZbvLw41T/C+Oe3CK9pIxmy0CE/yhxo1Q== X-Received: by 2002:a05:6000:42ca:b0:3a5:1222:ac64 with SMTP id ffacd0b85a97d-3a6ed63864emr725931f8f.38.1750835573693; Wed, 25 Jun 2025 00:12:53 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e805dc32sm3682707f8f.29.2025.06.25.00.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 00:12:53 -0700 (PDT) Message-ID: Date: Wed, 25 Jun 2025 09:12:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] i386/tdx: Don't build TDX for 32bit target To: Xiaoyao Li , Paolo Bonzini Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org References: <20250625034903.2770272-1-xiaoyao.li@intel.com> <20250625034903.2770272-3-xiaoyao.li@intel.com> <68ca9542-217b-40ae-b2ab-f3f160940aca@intel.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <68ca9542-217b-40ae-b2ab-f3f160940aca@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/25/25 08:36, Xiaoyao Li wrote: > On 6/25/2025 1:59 PM, Cédric Le Goater wrote: >> On 6/25/25 05:49, Xiaoyao Li wrote: >>> TDX cannot work on 32-bit host. It's also not worth supported TDX with >>> 32-bit QEMU. >>> >>> Thus, make TDX depends on !I386. >>> >>> Signed-off-by: Xiaoyao Li >>> --- >>>   hw/i386/Kconfig | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig >>> index 6fc353930985..c58802462a45 100644 >>> --- a/hw/i386/Kconfig >>> +++ b/hw/i386/Kconfig >>> @@ -13,7 +13,7 @@ config SGX >>>   config TDX >>>       bool >>>       select X86_FW_OVMF >>> -    depends on KVM >>> +    depends on KVM && !I386 >>>   config PC >>>       bool >> >> Both patches look OK. >> >> Out of curiosity, would the change below work as well (without patch 1) ? >> >> Thanks, >> >> C. >> >> >> >> >> @@ -13,7 +13,7 @@ config SGX >>   config TDX >>       bool >>       select X86_FW_OVMF >> -    depends on KVM >> +    depends on KVM && X86_64 >> >>   config PC >>       bool >> > > It works! (It turns out I'm not clever enough) > > Let's leave it to Paolo to pick. Could you please resend a v2 so someone can merge it while Paolo is on PTO ? Thanks, C.