qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: jdurgin@redhat.com, jcody@redhat.com, kwolf@redhat.com,
	mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}
Date: Fri, 24 Mar 2017 13:05:38 -0500	[thread overview]
Message-ID: <c3cb3590-0fe5-1c0f-0b55-6114d86a31a5@redhat.com> (raw)
In-Reply-To: <1490377482-13337-2-git-send-email-armbru@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

On 03/24/2017 12:44 PM, Markus Armbruster wrote:
> We use InetSocketAddress in the QAPI schema.  However, the code
> doesn't use inet_connect_saddr(), but formats "host" and "port" into a
> configuration string for rados_conf_set().  Thus, members "numeric",
> "to", "ipv4" and "ipv6" are silently ignored.  Not nice.  Example:
> 
>     -blockdev rbd,node-name=nn,pool=p,image=i,server.0.host=h0,server.0.port=12345,server.0.ipv4=off
> 
> Factor a suitable InetSocketAddressBase out of InetSocketAddress, and
> use that.  "numeric", "to", "ipv4" and "ipv6" are now rejected.

Are now rejected when using -blockdev-add or QMP, but are still
(silently) ignored when using -drive [fixed later in series].

> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi-schema.json     | 21 ++++++++++++++-------
>  qapi/block-core.json |  2 +-
>  2 files changed, 15 insertions(+), 8 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-03-24 18:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-24 17:44 [Qemu-devel] [PATCH RFC v2 0/9] rbd: Clean up API and code Markus Armbruster
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 1/9] rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6} Markus Armbruster
2017-03-24 18:05   ` Eric Blake [this message]
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 2/9] rbd: Fix to cleanly reject -drive without pool or image Markus Armbruster
2017-03-24 18:23   ` Eric Blake
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 3/9] rbd: Don't limit length of parameter values Markus Armbruster
2017-03-24 18:34   ` Eric Blake
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 4/9] rbd: Clean up after the previous commit Markus Armbruster
2017-03-24 18:44   ` Eric Blake
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 5/9] rbd: Don't accept -drive driver=rbd, keyvalue-pairs= Markus Armbruster
2017-03-24 18:53   ` Eric Blake
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 6/9] rbd: Clean up runtime_opts, fix -drive to reject filename Markus Armbruster
2017-03-24 18:55   ` Eric Blake
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 7/9] rbd: Clean up qemu_rbd_create()'s detour through QemuOpts Markus Armbruster
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 8/9] rbd: Rewrite the code to extract list-valued options Markus Armbruster
2017-03-24 19:03   ` Eric Blake
2017-03-24 17:44 ` [Qemu-devel] [PATCH RFC v2 9/9] rbd: Reject invalid authentication methods Markus Armbruster
2017-03-24 19:05   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3cb3590-0fe5-1c0f-0b55-6114d86a31a5@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jdurgin@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).