qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Cao Jiaxi <driver1998@foxmail.com>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion
Date: Fri, 3 May 2019 07:09:22 +0200	[thread overview]
Message-ID: <c3d707ff-0fa6-7f2a-014b-97946c00fd9d@redhat.com> (raw)
In-Reply-To: <20190503003650.10137-1-driver1998@foxmail.com>

On 03/05/2019 02.36, Cao Jiaxi wrote:
> The win2qemu[] is supposed to be the conversion table to convert between
> STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga.
> 
> But it was incorrectly written that it forces to set a GuestDiskBusType
> value to STORAGE_BUS_TYPE, which generates an enum conversion warning in clang.
> 
> Signed-off-by: Cao Jiaxi <driver1998@foxmail.com>
> ---
>  qga/commands-win32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index d40d61f605..6b67f16faf 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp)
>  
>  #ifdef CONFIG_QGA_NTDDSCSI
>  
> -static STORAGE_BUS_TYPE win2qemu[] = {
> +static GuestDiskBusType win2qemu[] = {
>      [BusTypeUnknown] = GUEST_DISK_BUS_TYPE_UNKNOWN,
>      [BusTypeScsi] = GUEST_DISK_BUS_TYPE_SCSI,
>      [BusTypeAtapi] = GUEST_DISK_BUS_TYPE_IDE,

Reviewed-by: Thomas Huth <thuth@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Cao Jiaxi <driver1998@foxmail.com>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Stefan Weil <sw@weilnetz.de>,
	Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion
Date: Fri, 3 May 2019 07:09:22 +0200	[thread overview]
Message-ID: <c3d707ff-0fa6-7f2a-014b-97946c00fd9d@redhat.com> (raw)
Message-ID: <20190503050922.RxJJmciCXLM2yFMUE-g1aMLEYMoizbHeGVe0II2UusQ@z> (raw)
In-Reply-To: <20190503003650.10137-1-driver1998@foxmail.com>

On 03/05/2019 02.36, Cao Jiaxi wrote:
> The win2qemu[] is supposed to be the conversion table to convert between
> STORAGE_BUS_TYPE in Windows SDK and GuestDiskBusType in qga.
> 
> But it was incorrectly written that it forces to set a GuestDiskBusType
> value to STORAGE_BUS_TYPE, which generates an enum conversion warning in clang.
> 
> Signed-off-by: Cao Jiaxi <driver1998@foxmail.com>
> ---
>  qga/commands-win32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index d40d61f605..6b67f16faf 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -457,7 +457,7 @@ void qmp_guest_file_flush(int64_t handle, Error **errp)
>  
>  #ifdef CONFIG_QGA_NTDDSCSI
>  
> -static STORAGE_BUS_TYPE win2qemu[] = {
> +static GuestDiskBusType win2qemu[] = {
>      [BusTypeUnknown] = GUEST_DISK_BUS_TYPE_UNKNOWN,
>      [BusTypeScsi] = GUEST_DISK_BUS_TYPE_SCSI,
>      [BusTypeAtapi] = GUEST_DISK_BUS_TYPE_IDE,

Reviewed-by: Thomas Huth <thuth@redhat.com>


  parent reply	other threads:[~2019-05-03  5:09 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03  0:22 [Qemu-devel] [PATCH v3 0/4] Initial Windows on ARM (AArch64 64-Bit) host support Cao Jiaxi
2019-05-03  0:22 ` Cao Jiaxi
2019-05-03  0:36 ` [Qemu-devel] [PATCH v3 1/4] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets Cao Jiaxi
2019-05-03  0:36   ` Cao Jiaxi
2019-05-03  5:06   ` Thomas Huth
2019-05-03  5:06     ` Thomas Huth
2019-05-03 15:23     ` Peter Maydell
2019-05-03 15:23       ` Peter Maydell
2019-05-03 15:56       ` Marc-André Lureau
2019-05-03 15:56         ` Marc-André Lureau
2019-05-03 16:23         ` Philippe Mathieu-Daudé
2019-05-03 16:23           ` Philippe Mathieu-Daudé
2019-05-03  0:36 ` [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion Cao Jiaxi
2019-05-03  0:36   ` Cao Jiaxi
2019-05-03  3:32   ` Richard Henderson
2019-05-03  3:32     ` Richard Henderson
2019-05-03  5:09   ` Thomas Huth [this message]
2019-05-03  5:09     ` Thomas Huth
2019-05-03  0:37 ` [Qemu-devel] [PATCH v3 3/4] util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64 Cao Jiaxi
2019-05-03  0:37   ` Cao Jiaxi
2019-05-03  3:31   ` Richard Henderson
2019-05-03  3:31     ` Richard Henderson
2019-05-03  5:10   ` Thomas Huth
2019-05-03  5:10     ` Thomas Huth
2019-05-03  0:37 ` [Qemu-devel] [PATCH v3 4/4] osdep: Fix mingw compilation regarding stdio formats Cao Jiaxi
2019-05-03  0:37   ` Cao Jiaxi
2019-05-03  5:11   ` Thomas Huth
2019-05-03  5:11     ` Thomas Huth
2019-05-03  5:28     ` Stefan Weil
2019-05-03  5:28       ` Stefan Weil
2019-05-03 10:19 ` [Qemu-devel] [PATCH v3 0/4] Initial Windows on ARM (AArch64 64-Bit) host support Philippe Mathieu-Daudé
2019-05-03 10:19   ` Philippe Mathieu-Daudé
2019-05-03 14:07   ` Peter Maydell
2019-05-03 14:07     ` Peter Maydell
     [not found] <20190503002258.9799-1-driver1998@foxmail.com>
2019-05-03  0:25 ` [Qemu-devel] [PATCH v3 2/4] qga: Fix mingw compilation warnings on enum conversion Cao Jiaxi
2019-05-03  0:25   ` Cao Jiaxi
2019-05-03  9:03   ` Philippe Mathieu-Daudé
2019-05-03  9:03     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3d707ff-0fa6-7f2a-014b-97946c00fd9d@redhat.com \
    --to=thuth@redhat.com \
    --cc=driver1998@foxmail.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).