From: Thomas Huth <thuth@redhat.com>
To: Stephen Checkoway <stephen.checkoway@oberlin.edu>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
Laurent Vivier <lvivier@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands
Date: Wed, 10 Apr 2019 16:39:21 +0200 [thread overview]
Message-ID: <c3d9ce6b-25d0-940a-7236-5b51a4d99bdc@redhat.com> (raw)
In-Reply-To: <98B3F0C7-6554-4455-B441-86605DA5D6C1@oberlin.edu>
On 09/04/2019 17.37, Stephen Checkoway wrote:
>
>
> On Apr 9, 2019, at 02:13, Thomas Huth <thuth@redhat.com> wrote:
>
>> We'd like to get rid of global_qtest in the long run (since it is
>> causing trouble for tests that run multiple instances of QEMU in
>> parallel, e.g. migration tests)... so if it is feasible, please don't
>> use it in new code anymore. Try to use a local variable in the function
>> that call qtest_initf() and pass the test state around via a parameter
>> to the functions that need it.
>
> One of the patches introduces a FlashConfig structure which gets passed around to all the functions. I could stuff the local qtest in there. The earlier patches would still use global_qtest. Would that be acceptable or would you prefer that global_qtest not appear in any of the patches?
Using FlashConfig sounds fine to me. If you need to use global_qtest in
some of the earlier patches, that's ok, too (especially if these go away
again in the later patches ;-)).
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Stephen Checkoway <stephen.checkoway@oberlin.edu>
Cc: Kevin Wolf <kwolf@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands
Date: Wed, 10 Apr 2019 16:39:21 +0200 [thread overview]
Message-ID: <c3d9ce6b-25d0-940a-7236-5b51a4d99bdc@redhat.com> (raw)
Message-ID: <20190410143921.scEKPNytYh_lQZqyzr_rJRJkiaQ7JkjrgqnxSuMb7kU@z> (raw)
In-Reply-To: <98B3F0C7-6554-4455-B441-86605DA5D6C1@oberlin.edu>
On 09/04/2019 17.37, Stephen Checkoway wrote:
>
>
> On Apr 9, 2019, at 02:13, Thomas Huth <thuth@redhat.com> wrote:
>
>> We'd like to get rid of global_qtest in the long run (since it is
>> causing trouble for tests that run multiple instances of QEMU in
>> parallel, e.g. migration tests)... so if it is feasible, please don't
>> use it in new code anymore. Try to use a local variable in the function
>> that call qtest_initf() and pass the test state around via a parameter
>> to the functions that need it.
>
> One of the patches introduces a FlashConfig structure which gets passed around to all the functions. I could stuff the local qtest in there. The earlier patches would still use global_qtest. Would that be acceptable or would you prefer that global_qtest not appear in any of the patches?
Using FlashConfig sounds fine to me. If you need to use global_qtest in
some of the earlier patches, that's ok, too (especially if these go away
again in the later patches ;-)).
Thomas
next prev parent reply other threads:[~2019-04-10 14:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 20:55 [Qemu-devel] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-09 6:13 ` Thomas Huth
2019-04-09 6:13 ` Thomas Huth
2019-04-09 7:45 ` Markus Armbruster
2019-04-09 7:45 ` Markus Armbruster
2019-04-09 8:16 ` Thomas Huth
2019-04-09 8:16 ` Thomas Huth
2019-04-09 8:35 ` Markus Armbruster
2019-04-09 8:35 ` Markus Armbruster
2019-04-09 8:40 ` Thomas Huth
2019-04-09 8:40 ` Thomas Huth
2019-04-09 8:50 ` Markus Armbruster
2019-04-09 8:50 ` Markus Armbruster
2019-04-09 15:37 ` Stephen Checkoway
2019-04-09 15:37 ` Stephen Checkoway
2019-04-10 14:39 ` Thomas Huth [this message]
2019-04-10 14:39 ` Thomas Huth
2019-04-08 20:55 ` [Qemu-devel] [PATCH 02/10] block/pflash_cfi02: Refactor, NFC intended Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 03/10] block/pflash_cfi02: Fix command address comparison Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 04/10] block/pflash_cfi02: Implement intereleaved flash devices Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 05/10] block/pflash_cfi02: Implement nonuniform sector sizes Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 06/10] block/pflash_cfi02: Fix CFI in autoselect mode Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 07/10] block/pflash_cfi02: Fix reset command not ignored during erase Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 08/10] block/pflash_cfi02: Implement multi-sector erase Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 09/10] block/pflash_cfi02: Implement erase suspend/resume Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 21:11 ` [Qemu-devel] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality no-reply
2019-04-08 21:11 ` no-reply
2019-04-09 10:34 ` Philippe Mathieu-Daudé
2019-04-09 10:34 ` Philippe Mathieu-Daudé
2019-04-09 15:55 ` Stephen Checkoway
2019-04-09 15:55 ` Stephen Checkoway
2019-04-09 16:15 ` Philippe Mathieu-Daudé
2019-04-09 16:15 ` Philippe Mathieu-Daudé
2019-04-09 18:00 ` Stephen Checkoway
2019-04-09 18:00 ` Stephen Checkoway
2019-04-18 21:00 ` Stephen Checkoway
2019-04-18 21:00 ` Stephen Checkoway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3d9ce6b-25d0-940a-7236-5b51a4d99bdc@redhat.com \
--to=thuth@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stephen.checkoway@oberlin.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).