qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality
@ 2019-04-08 20:55 Stephen Checkoway
  2019-04-08 20:55 ` Stephen Checkoway
                   ` (12 more replies)
  0 siblings, 13 replies; 50+ messages in thread
From: Stephen Checkoway @ 2019-04-08 20:55 UTC (permalink / raw)
  To: qemu-devel; +Cc: Kevin Wolf, Max Reitz, qemu-block, Stephen Checkoway

The goal of this patch series implement the following AMD command-set parallel
flash functionality:
- flash interleaving;
- nonuniform sector sizes;
- erase suspend/resume commands; and
- multi-sector erase.

During refactoring and implementation, I discovered several bugs that are
fixed here as well:
- flash commands use only 11-bits of the address in most cases, but the
  current code uses all of them [1];
- entering CFI mode from autoselect mode and then exiting CFI mode should
  return the chip to autoselect mode, but the current code returns to read
  array mode; and
- reset command should be ignored during sector/chip erase, but the current
  code performs the reset.

The first patch in the series adds a test for the existing behavior. Tests for
additional behavior/bug fixes are added in the relevant patch.

1. I found firmware in the wild that relies on the 11-bit address behavior,
   probably due to a bug in the firmware itself.

Stephen Checkoway (10):
  block/pflash_cfi02: Add test for supported commands
  block/pflash_cfi02: Refactor, NFC intended
  block/pflash_cfi02: Fix command address comparison
  block/pflash_cfi02: Implement intereleaved flash devices
  block/pflash_cfi02: Implement nonuniform sector sizes
  block/pflash_cfi02: Fix CFI in autoselect mode
  block/pflash_cfi02: Fix reset command not ignored during erase
  block/pflash_cfi02: Implement multi-sector erase
  block/pflash_cfi02: Implement erase suspend/resume
  block/pflash_cfi02: Use the chip erase time specified in the CFI table

 hw/block/pflash_cfi02.c   | 843 +++++++++++++++++++++++++++-----------
 tests/Makefile.include    |   2 +
 tests/pflash-cfi02-test.c | 757 ++++++++++++++++++++++++++++++++++
 3 files changed, 1367 insertions(+), 235 deletions(-)
 create mode 100644 tests/pflash-cfi02-test.c

-- 
2.20.1 (Apple Git-117)

^ permalink raw reply	[flat|nested] 50+ messages in thread

end of thread, other threads:[~2019-04-18 21:15 UTC | newest]

Thread overview: 50+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-08 20:55 [Qemu-devel] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality Stephen Checkoway
2019-04-08 20:55 ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-09  6:13   ` Thomas Huth
2019-04-09  6:13     ` Thomas Huth
2019-04-09  7:45     ` Markus Armbruster
2019-04-09  7:45       ` Markus Armbruster
2019-04-09  8:16       ` Thomas Huth
2019-04-09  8:16         ` Thomas Huth
2019-04-09  8:35         ` Markus Armbruster
2019-04-09  8:35           ` Markus Armbruster
2019-04-09  8:40           ` Thomas Huth
2019-04-09  8:40             ` Thomas Huth
2019-04-09  8:50             ` Markus Armbruster
2019-04-09  8:50               ` Markus Armbruster
2019-04-09 15:37     ` Stephen Checkoway
2019-04-09 15:37       ` Stephen Checkoway
2019-04-10 14:39       ` Thomas Huth
2019-04-10 14:39         ` Thomas Huth
2019-04-08 20:55 ` [Qemu-devel] [PATCH 02/10] block/pflash_cfi02: Refactor, NFC intended Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 03/10] block/pflash_cfi02: Fix command address comparison Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 04/10] block/pflash_cfi02: Implement intereleaved flash devices Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 05/10] block/pflash_cfi02: Implement nonuniform sector sizes Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 06/10] block/pflash_cfi02: Fix CFI in autoselect mode Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 07/10] block/pflash_cfi02: Fix reset command not ignored during erase Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 08/10] block/pflash_cfi02: Implement multi-sector erase Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 09/10] block/pflash_cfi02: Implement erase suspend/resume Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 20:55 ` [Qemu-devel] [PATCH 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table Stephen Checkoway
2019-04-08 20:55   ` Stephen Checkoway
2019-04-08 21:11 ` [Qemu-devel] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality no-reply
2019-04-08 21:11   ` no-reply
2019-04-09 10:34 ` Philippe Mathieu-Daudé
2019-04-09 10:34   ` Philippe Mathieu-Daudé
2019-04-09 15:55   ` Stephen Checkoway
2019-04-09 15:55     ` Stephen Checkoway
2019-04-09 16:15     ` Philippe Mathieu-Daudé
2019-04-09 16:15       ` Philippe Mathieu-Daudé
2019-04-09 18:00       ` Stephen Checkoway
2019-04-09 18:00         ` Stephen Checkoway
2019-04-18 21:00       ` Stephen Checkoway
2019-04-18 21:00         ` Stephen Checkoway

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).