From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, peter.maydell@linaro.org, peterx@redhat.com,
pbonzini@redhat.com, alex.williamson@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 5/6] hw/arm/smmuv3: Log a guest error when decoding an invalid STE
Date: Mon, 1 Jul 2019 11:58:04 +0200 [thread overview]
Message-ID: <c3ea9b07-3f5c-a454-4971-9b11afcb3d02@redhat.com> (raw)
In-Reply-To: <20190701093034.18873-6-eric.auger@redhat.com>
On 7/1/19 11:30 AM, Eric Auger wrote:
> Log a guest error when encountering an invalid STE.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
> hw/arm/smmuv3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index 384c02cb91..2e270a0f07 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -320,6 +320,7 @@ static int decode_ste(SMMUv3State *s, SMMUTransCfg *cfg,
> uint32_t config;
>
> if (!STE_VALID(ste)) {
> + qemu_log_mask(LOG_GUEST_ERROR, "invalid STE\n");
> goto bad_ste;
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-07-01 10:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 9:30 [Qemu-devel] [PATCH v2 0/6] ARM SMMUv3: Fix spurious notification errors and stall with vfio-pci Eric Auger
2019-07-01 9:30 ` [Qemu-devel] [PATCH v2 1/6] memory: Remove unused memory_region_iommu_replay_all() Eric Auger
2019-07-01 9:58 ` Philippe Mathieu-Daudé
2019-07-03 5:41 ` Peter Xu
2019-07-01 9:30 ` [Qemu-devel] [PATCH v2 2/6] memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute Eric Auger
2019-07-03 5:42 ` Peter Xu
2019-07-03 9:10 ` Auger Eric
2019-07-01 9:30 ` [Qemu-devel] [PATCH v2 3/6] hw/vfio/common: Do not replay IOMMU mappings in nested case Eric Auger
2019-07-03 5:41 ` Peter Xu
2019-07-03 9:04 ` Auger Eric
2019-07-03 10:21 ` Peter Xu
2019-07-03 10:45 ` Auger Eric
2019-07-04 2:36 ` Peter Xu
2019-07-01 9:30 ` [Qemu-devel] [PATCH v2 4/6] hw/arm/smmuv3: Advertise VFIO_NESTED Eric Auger
2019-07-01 9:30 ` [Qemu-devel] [PATCH v2 5/6] hw/arm/smmuv3: Log a guest error when decoding an invalid STE Eric Auger
2019-07-01 9:58 ` Philippe Mathieu-Daudé [this message]
2019-07-01 9:30 ` [Qemu-devel] [PATCH v2 6/6] hw/arm/smmuv3: Remove spurious error messages on IOVA invalidations Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ea9b07-3f5c-a454-4971-9b11afcb3d02@redhat.com \
--to=philmd@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).