From: Stefan Weil <sw@weilnetz.de>
To: Brad Smith <brad@comstyle.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] meson.build: Support ncurses on MacOS
Date: Sun, 13 Jun 2021 08:33:18 +0200 [thread overview]
Message-ID: <c3f3e9af-c81e-078c-5200-e2532a468cf7@weilnetz.de> (raw)
In-Reply-To: <202eedd1-eb24-5463-c17a-64e146b95421@comstyle.com>
Am 13.06.21 um 03:40 schrieb Brad Smith:
> This same problem also applies to OpenBSD as we have the same
> version of ncurses with support for wide characters. I have a similar
> patch in our QEMU port.
Then we should either extend the conditional statement to handle OpenBSD
as well, or simply define both macros unconditionally:
# Newer versions of curses use NCURSES_WIDECHAR.
# Older versions (e. g. on MacOS, OpenBSD) still require
_XOPEN_SOURCE_EXTENDED.
curses_compile_args = ['-DNCURSES_WIDECHAR=1',
'-D_XOPEN_SOURCE_EXTENDED=1']
Defining only _XOPEN_SOURCE_EXTENDED would also work with old and new
versions, so that's another option.
Stefan
next prev parent reply other threads:[~2021-06-13 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 8:03 [PATCH] meson.build: Support ncurses on MacOS Stefan Weil
2021-06-13 1:40 ` Brad Smith
2021-06-13 6:33 ` Stefan Weil [this message]
2021-06-14 5:45 ` Philippe Mathieu-Daudé
2021-06-15 1:53 ` Brad Smith
2021-11-09 17:49 ` Stefan Weil
2021-11-09 18:30 ` Daniel P. Berrangé
-- strict thread matches above, loose matches on Subject: below --
2021-06-12 8:51 Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f3e9af-c81e-078c-5200-e2532a468cf7@weilnetz.de \
--to=sw@weilnetz.de \
--cc=berrange@redhat.com \
--cc=brad@comstyle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).