From: Richard Henderson <richard.henderson@linaro.org>
To: lixinyu <precinct@mail.ustc.edu.cn>, qemu-devel@nongnu.org
Cc: arikalo@wavecomp.com, aurelien@aurel32.net
Subject: Re: [PATCH] tcg/mips: mips sync* encode error
Date: Sat, 11 Apr 2020 11:07:59 -0700 [thread overview]
Message-ID: <c3fac325-df9a-be96-72d0-1898635afef9@linaro.org> (raw)
In-Reply-To: <20200411124612.12560-1-precinct@mail.ustc.edu.cn>
On 4/11/20 5:46 AM, lixinyu wrote:
> OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and
> OPC_SYNC_RMB have wrong encode. According to the mips manual,
> their encode should be 'OPC_SYNC | 0x?? << 6' rather than
> 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction
> errors. These instructions often appear with multi-threaded
> simulation.
Good catch.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Queued to tcg-for-5.0.
r~
next prev parent reply other threads:[~2020-04-11 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 12:46 [PATCH] tcg/mips: mips sync* encode error lixinyu
2020-04-11 18:07 ` Richard Henderson [this message]
2020-04-11 18:37 ` Aleksandar Markovic
2020-04-12 17:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3fac325-df9a-be96-72d0-1898635afef9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=precinct@mail.ustc.edu.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).